-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring upstream code to DRY it out a bit #207
Conversation
4272b5b
to
44d7d8d
Compare
/ok-to-test |
I submitted 2 PRs that reclaimed value for the last few commits (the styling). We should get the first 5 too, but they don't include the story point changes, so that's been tying me up. |
@Zyzyx, I've rebased this branch on the branch in #219 which is on the end of I think I've properly incorporated the Story Point work from #203, but I need to check my work. |
OK, it looks good. |
d025ca5
to
e4afd10
Compare
a423360
to
ec7892d
Compare
abb2ff4
to
a7dcd3b
Compare
This branch was merged as a series of individual PRs. |
This PR is a series of refactorings and other modest changes to the
upstream_*.py
modules. The intention is that there be no overall functional change; however, internally, the changes remove a bunch of code duplication, shedding a little over 25% of the previous code.Each of the first several commits is targeted at removing a particular code duplication. The commits after that are more code-quality/stylistic changes.
I recommend reviewing it one commit at a time.
A couple of notes on the tests:
requests
package is to be patched), so I think the unit tests still did their job.