Tweak downstream issue code

release-engineering · Nov 22, 2024 · a7dcd3b · a7dcd3b
1 parent f6d94c7
commit a7dcd3b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/sync2jira/downstream_issue.py b/sync2jira/downstream_issue.py
@@ -992,7 +992,7 @@ def _update_github_project_fields(client, existing, issue,
                 log.error("Configuration error: Missing 'storypoints' in `default_jira_fields`")
                 continue
             try:
-                existing.update({jirafieldname: fieldvalue})
+                existing[jirafieldname] = fieldvalue
             except JIRAError as err:
                 # Add a comment to indicate there was an issue
                 client.add_comment(existing, f"Error updating GitHub project storypoints field: {err}")
@@ -1004,7 +1004,7 @@ def _update_github_project_fields(client, existing, issue,
             jira_priority = values.get('options', {}).get(fieldvalue)
             if jira_priority:
                 try:
-                    existing.update({jirafieldname: {'name': jira_priority}})
+                    existing[jirafieldname] = {'name': jira_priority}
                 except JIRAError as err:
                     # Add a comment to indicate there was an issue
                     client.add_comment(existing, f"Error updating GitHub project priority field: {err}")

diff --git a/tests/test_downstream_issue.py b/tests/test_downstream_issue.py
@@ -1681,9 +1681,10 @@ def test_update_github_project_fields_storypoints(self, mock_client):
          "storypoints": {
            "gh_field": "Estimate"
          }}
-        d._update_github_project_fields(mock_client, self.mock_downstream, self.mock_issue,
+        existing = {}
+        d._update_github_project_fields(mock_client, existing, self.mock_issue,
                                   github_project_fields, self.mock_config)
-        self.mock_downstream.update.assert_called_with({'customfield_12310243': 2})
+        self.assertEqual(existing['customfield_12310243'], 2)
 
 
     @mock.patch('jira.client.JIRA')
@@ -1703,6 +1704,7 @@ def test_update_github_project_fields_priority(self, mock_client):
              "P4": "Optional",
              "P5": "Trivial"
         }}}
-        d._update_github_project_fields(mock_client, self.mock_downstream, self.mock_issue,
+        existing = {}
+        d._update_github_project_fields(mock_client, existing, self.mock_issue,
                                   github_project_fields, self.mock_config)
-        self.mock_downstream.update.assert_called_with({'priority': {'name': 'Critical'}})
+        self.assertEqual(existing['priority'], {'name': 'Critical'})