Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart testing configuration per individual Github action pipeline #618

Merged
merged 1 commit into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/ct.yaml → .github/ct-kminion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ target-branch: main
helm-extra-args: --timeout 900s
chart-repos:
- redpanda=https://charts.redpanda.com

charts:
- charts/kminion
22 changes: 22 additions & 0 deletions .github/ct-operator.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
debug: true
remote: origin
target-branch: main
helm-extra-args: --timeout 900s
chart-repos:
- redpanda=https://charts.redpanda.com
charts:
- charts/operator
22 changes: 22 additions & 0 deletions .github/ct-redpanda.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
debug: true
remote: origin
target-branch: main
helm-extra-args: --timeout 900s
chart-repos:
- redpanda=https://charts.redpanda.com
charts:
- charts/redpanda
7 changes: 3 additions & 4 deletions .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
version: v3.8.0-1

- name: Run chart-testing (lint)
run: ct lint --all --config .github/ct.yaml
run: ct lint --all --config .github/ct-redpanda.yaml
test:
name: Run ct tests for ci values matching ${{ matrix.testvaluespattern }} for Redpanda version ${{ matrix.version }}
strategy:
Expand Down Expand Up @@ -136,7 +136,6 @@ jobs:
ct install \
--github-groups \
--upgrade \
--config .github/ct.yaml \
--config .github/ct-redpanda.yaml \
--helm-extra-set-args="--set=image.tag=${{ matrix.version }}" \
--skip-missing-values \
--charts=charts/redpanda
--skip-missing-values
5 changes: 2 additions & 3 deletions .github/workflows/nightly_redpanda_tip.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ jobs:
run: |
ct install \
--github-groups \
--config .github/ct.yaml \
--config .github/ct-redpanda.yaml \
--helm-extra-set-args="--set=image.tag=${{ steps.latestTag.outputs.TAG }} --set=image.repository=redpandadata/redpanda-nightly" \
--skip-missing-values \
--charts=charts/redpanda
--skip-missing-values
7 changes: 3 additions & 4 deletions .github/workflows/pull_requests-operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
version: v3.8.0-1

- name: Run chart-testing (lint)
run: ct lint --config .github/ct.yaml --github-groups --chart-dirs=charts/operator
run: ct lint --config .github/ct-operator.yaml --github-groups

check-values:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --chart-dirs=charts/operator )
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
echo $changed
if [[ -n "$changed" ]]; then
echo changed="true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -141,9 +141,8 @@ jobs:
ct install \
--github-groups \
--upgrade \
--config .github/ct.yaml \
--config .github/ct-operator.yaml \
--skip-missing-values \
--chart-dirs=charts/operator \
--target-branch ${{ github.event.repository.default_branch }}
summary:
if: always()
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pull_requests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
version: v3.8.0-1

- name: Run chart-testing (lint)
run: ct lint --config .github/ct.yaml --github-groups
run: ct lint --config .github/ct-redpanda.yaml --github-groups

check-values:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --chart-dirs=charts/redpanda )
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
echo $changed
if [[ -n "$changed" ]]; then
echo changed="true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
ct install \
--github-groups \
--upgrade \
--config .github/ct.yaml \
--config .github/ct-redpanda.yaml \
--helm-extra-set-args="--set=image.tag=${{ matrix.version }}" \
--skip-missing-values \
--chart-dirs=charts/redpanda \
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/pull_requests_from_origin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --chart-dirs=charts/redpanda )
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
echo $changed
if [[ -n "$changed" ]]; then
echo changed="true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -135,8 +135,7 @@ jobs:
ct install \
--github-groups \
--upgrade \
--config .github/ct.yaml \
--config .github/ct-redpanda.yaml \
--helm-extra-set-args="--set=image.tag=${{ matrix.version }}" \
--skip-missing-values \
--chart-dirs=charts/redpanda \
--target-branch ${{ github.event.repository.default_branch }}
7 changes: 3 additions & 4 deletions .github/workflows/pull_requests_kminion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
version: v3.8.0-1

- name: Run chart-testing (lint)
run: ct lint --config .github/ct.yaml --github-groups --chart-dirs=charts/kminion
run: ct lint --config .github/ct-kminion.yaml --github-groups

check-values:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --chart-dirs=charts/kminion )
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
echo $changed
if [[ -n "$changed" ]]; then
echo changed="true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -143,7 +143,6 @@ jobs:
ct install \
--github-groups \
--upgrade \
--config .github/ct.yaml \
--config .github/ct-kminion.yaml \
--skip-missing-values \
--chart-dirs=charts/kminion \
--target-branch ${{ github.event.repository.default_branch }}