Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart testing configuration per individual Github action pipeline #618

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

RafalKorepta
Copy link
Contributor

--chart-dirs was not working as I would think.

REF:
https://github.com/redpanda-data/helm-charts/actions/runs/5678517663/job/15388898267#step:7:14

$ ct lint --config .github/ct.yaml --github-groups --chart-dirs=charts/kminion
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git rev-parse --verify main
>>> git merge-base origin/main HEAD
>>> git diff --find-renames --name-only aba186603a055[2](https://github.com/redpanda-data/helm-charts/actions/runs/5678517663/job/15388898267#step:7:2)a0d65d8df9d8c4a[3](https://github.com/redpanda-data/helm-charts/actions/runs/5678517663/job/15388898267#step:7:3)8cde70b9[5](https://github.com/redpanda-data/helm-charts/actions/runs/5678517663/job/15388898267#step:7:5)3 -- charts/kminion
Directory "charts/kminion/ci" is not a valid chart directory. Skipping...
Test Results
  No chart changes detected.
All charts linted successfully

https://github.com/redpanda-data/helm-charts/pull/616/files

Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafalKorepta RafalKorepta merged commit 2b59ed6 into redpanda-data:main Jul 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants