-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin 2.0.20 support #1826
Kotlin 2.0.20 support #1826
Conversation
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @KitsuneAlex. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
cd223c7
to
c2abd1d
Compare
This seems to be the major holdback with Kotlin 2.0.20 right now. |
...ages/plugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/RealmModelLoweringExtension.kt
Outdated
Show resolved
Hide resolved
Doneso :) |
How to ping Realm to actually merge this and release as a hotfix? It's not so great not to support the latest stable release.. |
Giving a respectful bump @nirinchev :) |
Also tagging @fealebenpae @tgoyne @kraenhansen and @nicola-cab because this specific repository seems a little inactive atm and i really need this fix at work if possible. |
Hey, apologies for the delays here - it's a period of multiple vacations as well as parental leaves, which has left the Kotlin team very understaffed. We expect folks to start coming back from their leaves mid-September and we'll try to prioritize this PR. |
Thank you very very much. And sorry if i came off as spammy here! |
Not at all, it's a fair ask! |
Any news?, its a blocker for some Visma companies to upgrade kotlin as well. |
@nhachicha that's the PR I mentioned yesterday. Can you take a look and if all looks good, we can do a release with the latest Core fixes + this. |
Update changelog with deprecation
Thanks for the PR @KitsuneAlex some updates:
I'm grouping potential fixes in #1830 if you want to follow the progress |
* Update Kotlin to 2.0.20 & dependencies * @cla-bot check * Fix double whitespace in exception message in RealmModelLoweringEExtension * Fix crash with Kotlin 2.0.20 via #1826 Update changelog with deprecation * Support Kotlin 2.0.20 * clean up * update Readme * Fixes RealmModelLoweringExtension * Bump version & update compiler plugin for Sync * update integration tests * Remove sync packages * Remove sync code and analytics * Clean up compiler plugin * Remove asymmetric objects * linting * Clean up error codes and categories * Remove system utils constants * Update GHA * linting * Remove more constants * update tests * Fix rogue char * Update benchmarks * Remove more sync references * Fix compiler plugin not being applied --------- Co-authored-by: KitsuneAlex <[email protected]> Co-authored-by: Nabil Hachicha <[email protected]>
Fixes #1825