Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 2.0.20 support #1826

Closed
wants to merge 3 commits into from
Closed

Conversation

KitsuneAlex
Copy link
Contributor

Fixes #1825

Copy link

cla-bot bot commented Aug 27, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @KitsuneAlex. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@KitsuneAlex
Copy link
Contributor Author

This seems to be the major holdback with Kotlin 2.0.20 right now.

@KitsuneAlex KitsuneAlex marked this pull request as ready for review August 27, 2024 18:32
@KitsuneAlex
Copy link
Contributor Author

Doneso :)

@pvdmde
Copy link

pvdmde commented Sep 3, 2024

How to ping Realm to actually merge this and release as a hotfix?

It's not so great not to support the latest stable release..

@KitsuneAlex
Copy link
Contributor Author

Giving a respectful bump @nirinchev :)

@KitsuneAlex
Copy link
Contributor Author

Also tagging @fealebenpae @tgoyne @kraenhansen and @nicola-cab because this specific repository seems a little inactive atm and i really need this fix at work if possible.

@nirinchev
Copy link
Member

Hey, apologies for the delays here - it's a period of multiple vacations as well as parental leaves, which has left the Kotlin team very understaffed. We expect folks to start coming back from their leaves mid-September and we'll try to prioritize this PR.

@KitsuneAlex
Copy link
Contributor Author

Hey, apologies for the delays here - it's a period of multiple vacations as well as parental leaves, which has left the Kotlin team very understaffed. We expect folks to start coming back from their leaves mid-September and we'll try to prioritize this PR.

Thank you very very much. And sorry if i came off as spammy here!

@nirinchev
Copy link
Member

Not at all, it's a fair ask!

@AlexKatonaVisma
Copy link

AlexKatonaVisma commented Sep 10, 2024

Any news?, its a blocker for some Visma companies to upgrade kotlin as well.

@nirinchev
Copy link
Member

@nhachicha that's the PR I mentioned yesterday. Can you take a look and if all looks good, we can do a release with the latest Core fixes + this.

nhachicha added a commit that referenced this pull request Sep 10, 2024
Update changelog with deprecation
@nhachicha
Copy link
Collaborator

Thanks for the PR @KitsuneAlex some updates:
While this PR address some aspects, JetBrains introduced more compiler changes:

I'm grouping potential fixes in #1830 if you want to follow the progress

nhachicha added a commit that referenced this pull request Oct 3, 2024
* Update Kotlin to 2.0.20 & dependencies

* @cla-bot check

* Fix double whitespace in exception message in RealmModelLoweringEExtension

* Fix crash with Kotlin 2.0.20 via #1826
Update changelog with deprecation

* Support Kotlin 2.0.20

* clean up

* update Readme

* Fixes RealmModelLoweringExtension

* Bump version & update compiler plugin for Sync

* update integration tests

* Remove sync packages

* Remove sync code and analytics

* Clean up compiler plugin

* Remove asymmetric objects

* linting

* Clean up error codes and categories

* Remove system utils constants

* Update GHA

* linting

* Remove more constants

* update tests

* Fix rogue char

* Update benchmarks

* Remove more sync references

* Fix compiler plugin not being applied

---------

Co-authored-by: KitsuneAlex <[email protected]>
Co-authored-by: Nabil Hachicha <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin 2.0.20 support
5 participants