[RKOTLIN-1062] Remove CMake required version #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementetb
changed the title
rorbech
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
There is more to it than this to control the cmake version. We also have a hardcoded version for docker image to build the Linux so-files and a VERSION_CMAKE GHA-variable. We should somehow align all of them ... but I guess this unblocks us for now, so if CI is happy.
rorbech
added a commit
that referenced
this pull request
Apr 17, 2024
* Prepare next dev iteration * 🔄 Synced file(s) with realm/ci-actions (#1689) * Removing Jenkins switching to Github Action for CI/CD (#1698) * Remove cmake required version (#1710) * [RKOTLIN-1031] Update to Core 14.4.1 (#1668) * [RKOTLIN-825] Remove unused docker image (#1699) * Update URL to documentation * RKOTLIN-1033: Update default base url (#1718) * Upgrade to Core 14.5.0 * Upgrade to Core 14.5.1. * Apply suggestions from code review --------- Co-authored-by: Nabil Hachicha <[email protected]> Co-authored-by: Yavor Georgiev <[email protected]> Co-authored-by: realm-ci <[email protected]> Co-authored-by: Nabil Hachicha <[email protected]> Co-authored-by: clementetb <[email protected]> Co-authored-by: Kenneth Geisshirt <[email protected]> Co-authored-by: Kenneth Geisshirt <[email protected]> Co-authored-by: Nikola Irinchev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the fixed cmake version required by cinterop to rely on Cores cmake minimum version.