Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmake required fixed version #1711

Closed
sync-by-unito bot opened this issue Mar 26, 2024 · 2 comments
Closed

Remove cmake required fixed version #1711

sync-by-unito bot opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 26, 2024

The kotlin project defines a fixed version for cmake, causing some extra steps as it forces to search, download and install it manually rather than using an app repository like brew.

Remove the fixed version to rely on cores minimum one.

Copy link
Author

sync-by-unito bot commented Mar 26, 2024

➤ PM Bot commented:

Jira ticket: RKOTLIN-1062

@rorbech
Copy link
Contributor

rorbech commented Apr 9, 2024

This was tried fixed by #1710, but that caused cinterop Android build to use the default cmake for the used NDK (23.2.8568313). This does not meet the cmake_minimum_required of core, so reworked to used whatever cmake is available on the path and rely on cmake to exit if that does not meet the minimum required version.

@rorbech rorbech closed this as completed Apr 9, 2024
@sync-by-unito sync-by-unito bot assigned rorbech and unassigned clementetb Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants