Remove gps.h and use distro's version #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the copy of gps.h from the code, relying instead on the gps.h shipped with the distro (by libgps-dev). That much is simple enough, but the current version of libgps has moved from using doubles (as timestamp_t) to timespec_t structures for greater accuracy. This patch also adds some trivial fixes for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the main-inclusion review process for the userland package in Ubuntu, we noticed that the camera binaries are attempting to dynamically load a version of libgps that doesn't exist in Ubuntu (.so.23 instead of .so.26).
This patch removes the copy of gps.h from the code, relying instead on the
gps.hshipped with the distro (by libgps-dev which I've added as a build-dep for our release).That much is simple enough, but the current version of libgps in Ubuntu has moved from using doubles (as
timestamp_t) totimespec_tstructures for greater accuracy. This patch also adds some trivial fixes for this change too.For this reason, this patch shouldn't be merged for Raspbian Buster. If you want the gps.h removal in Raspbian Buster, I'm happy to split the patch into two, but I thought it might be better to simply leave this open until Raspbian Bullseye?