Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshotOfLastVideoBuffer was not working #309

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

snapshotOfLastVideoBuffer was not working #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
f840c39
fixed thumbnail generation - context wasn't loading properly
GabeRoze May 17, 2016
a4c320e
added export at URL
GabeRoze May 18, 2016
ada3d74
added a fix to prevent video from recording until first audio has bee…
GabeRoze Jun 11, 2016
3b35197
changed videlo quality to kCVPixelFormatType_420YpCbCr8BiPlanarFullRange
GabeRoze Jun 14, 2016
610f9ce
fixed video/audio sync
GabeRoze Jun 15, 2016
ee4df5b
modified preventing video capture until first audio captured
GabeRoze Jun 15, 2016
dcc5342
Merge branch 'master' of https://github.com/rFlex/SCRecorder
GabeRoze Jun 23, 2016
6299dfe
Merge remote-tracking branch 'upstream/master'
GabeRoze Aug 30, 2016
961a9f8
bug fix
GabeRoze Jun 7, 2017
77f1bf6
bug fix
GabeRoze Jun 8, 2017
53f02b6
undid fixes cuz they broke more
GabeRoze Jun 8, 2017
0842a6c
added check to see if configuring
GabeRoze Jun 8, 2017
23c3e75
crash fixes
GabeRoze Jun 8, 2017
1740a59
crash fixes
GabeRoze Jun 16, 2017
a4ecb92
fix for double reconfigure being called
GabeRoze Jul 25, 2017
77ec374
fix for double reconfigure being called (crash)
GabeRoze Jul 25, 2017
736c59a
bug fix
GabeRoze Jul 31, 2017
8df62e2
bug fix
GabeRoze Sep 5, 2017
09661c3
updated pixel format for all the things so video looks better
GabeRoze Sep 6, 2017
c133c34
video range now
GabeRoze Oct 19, 2017
0e8aee8
Merge remote-tracking branch 'origin/master'
GabeRoze Oct 19, 2017
c1593e0
videoConfiguration.overlay kCVPixelBufferPixelFormatTypeKey
pixeled Mar 13, 2018
1e4ea86
retention oddness
pixeled Mar 13, 2018
67a1b3a
memory/arc fixes
pixeled Mar 13, 2018
b0b9351
detaching audio for haptic goodness
pixeled May 9, 2018
591edba
haptic fix
pixeled May 17, 2018
ba963e3
on the fly audio leveling
pixeled May 17, 2018
62b10d6
more touchup
pixeled May 18, 2018
260f95e
final audio goodness
pixeled May 18, 2018
c775aa9
exporting larger video tracks in composition
pixeled Jun 5, 2018
3a91173
overlay muting support
pixeled Jun 6, 2018
748e00a
warnings
pixeled Jun 8, 2018
d321424
warning removal
pixeled Jun 11, 2018
d2342fa
#500 code work
pixeled Jun 27, 2018
37b1841
crashlytics hang - multiple dispatch_sync oddness fix
pixeled Aug 19, 2018
6b0e5af
now can use hvec
GabeRoze Nov 11, 2018
7a1406a
updated how settings are figured out
GabeRoze Nov 12, 2018
74e750d
nullability fixes
GabeRoze Nov 12, 2018
27decfa
recommended settings updates
GabeRoze Nov 13, 2018
bb340d9
highest available format
GabeRoze Nov 13, 2018
44ab7ab
also returning FPS now
GabeRoze Nov 13, 2018
a8ed327
config updates
GabeRoze Nov 13, 2018
ca9e798
highest available 16x9 format
GabeRoze Nov 14, 2018
1bccdba
added a clause that lets us set our own sizes using the recommended s…
GabeRoze Nov 14, 2018
ab2a57b
video buffers delay handling
yakovlev0509 Dec 26, 2018
edc0c68
video recording fix with sync. Screenshots disappear from timeline #39
yakovlev0509 Dec 27, 2018
7ab3e7f
ios 11 crash fix
Mar 26, 2019
3ee4703
pause/resume functionality added for AssetExportSession
yakovlev0509 Jul 31, 2019
6006095
pause/resume fix
yakovlev0509 Aug 1, 2019
fde242d
check whether cmtime is numeric
yakovlev0509 Aug 6, 2019
5e29710
fixed missing video buffers in processing queue
yakovlev0509 Nov 12, 2019
4fdc2f6
merge of segments disabled if only one segment is present
yakovlev0509 Mar 4, 2020
0086b44
memory consumption reduced for creating of last video buffer snapshot
yakovlev0509 Sep 18, 2020
97a2a7b
option to render export overlay layer on main thread
yakovlev0509 Nov 23, 2020
983f802
added delegate method to get audio sample buffers while not recording
yakovlev0509 Jan 22, 2021
3e2bfff
export cancelation fix
yakovlev0509 Mar 26, 2021
b275ed0
export cancelation fix
yakovlev0509 May 25, 2021
f50f9fe
podspec update
yakovlev0509 May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Examples/ObjC/SCRecorderExamples.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
objects = {

/* Begin PBXBuildFile section */
90A0D7DE1BC7367A008F1BB0 /* Launch Screen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 90A0D7DD1BC7367A008F1BB0 /* Launch Screen.storyboard */; settings = {ASSET_TAGS = (); }; };
90A0D7DE1BC7367A008F1BB0 /* Launch Screen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 90A0D7DD1BC7367A008F1BB0 /* Launch Screen.storyboard */; };
90D4FBED1BC6DDEC0017748D /* Metal.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 90D4FBEC1BC6DDEC0017748D /* Metal.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
DC10CF251ACFD082009880C4 /* libSCRecorder.a in Frameworks */ = {isa = PBXBuildFile; fileRef = DC10CF1E1ACFCF6E009880C4 /* libSCRecorder.a */; };
DC1485DD1AFB78F2004896E9 /* a_filter.cisf in Resources */ = {isa = PBXBuildFile; fileRef = DC1485DC1AFB78F2004896E9 /* a_filter.cisf */; };
Expand Down Expand Up @@ -324,7 +324,7 @@
LastUpgradeCheck = 0510;
TargetAttributes = {
DC7F370718FC2A0D00D54901 = {
DevelopmentTeam = S9T665AXM4;
DevelopmentTeam = D82RJZ5422;
};
};
};
Expand Down Expand Up @@ -515,6 +515,7 @@
CODE_SIGN_IDENTITY = "iPhone Developer";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
DEFINES_MODULE = NO;
DEVELOPMENT_TEAM = D82RJZ5422;
ENABLE_BITCODE = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "Sources/SCRecorderExamples-Prefix.pch";
Expand All @@ -524,7 +525,7 @@
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
);
INFOPLIST_FILE = "Sources/SCRecorderExamples-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
OTHER_LDFLAGS = (
"-all_load",
"-ObjC",
Expand All @@ -544,6 +545,7 @@
CODE_SIGN_IDENTITY = "iPhone Developer";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
DEFINES_MODULE = NO;
DEVELOPMENT_TEAM = D82RJZ5422;
ENABLE_BITCODE = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "Sources/SCRecorderExamples-Prefix.pch";
Expand All @@ -553,7 +555,7 @@
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
);
INFOPLIST_FILE = "Sources/SCRecorderExamples-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
OTHER_LDFLAGS = (
"-all_load",
"-ObjC",
Expand Down
413 changes: 183 additions & 230 deletions Examples/ObjC/Sources/Main.storyboard
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Examples/ObjC/Sources/SCAudioRecordViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ - (void)recorder:(SCRecorder *)recorder didAppendAudioSampleBuffer:(SCRecordSess

- (void)deleteRecordSession {
[self.player setItemByAsset:nil];
[_recordSession removeAllSegments];
// [_recordSession removeAllSegments];
_recordSession = nil;
}

Expand Down
6 changes: 6 additions & 0 deletions Examples/ObjC/Sources/SCRecorderExamples-Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
<string>1.0</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>NSCameraUsageDescription</key>
<string>tor record</string>
<key>NSMicrophoneUsageDescription</key>
<string>to mic</string>
<key>NSPhotoLibraryUsageDescription</key>
<string>gimee fotos acces</string>
<key>UILaunchStoryboardName</key>
<string>Launch Screen</string>
<key>UIMainStoryboardFile</key>
Expand Down
2 changes: 2 additions & 0 deletions Examples/ObjC/Sources/SCRecorderViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
@property (weak, nonatomic) IBOutlet UIView *toolsContainerView;
@property (weak, nonatomic) IBOutlet UIButton *openToolsButton;

@property (strong, nonatomic) UILongPressGestureRecognizer *longPressGestureRecognizer;

- (IBAction)switchCameraMode:(id)sender;
- (IBAction)switchFlash:(id)sender;
- (IBAction)capturePhoto:(id)sender;
Expand Down
Loading