-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapshotOfLastVideoBuffer was not working #309
base: master
Are you sure you want to change the base?
Conversation
lol small world |
hah fancy meeting you here. Ever figure out what was wrong with your AVPlayer? |
Not yet, I took a break from it. Had some more people reach out to help, some promising leads. I may just move to paging. |
Hey, that's a great fix. Could you please refactor your change on mergeSegmentsUsingPreset so the code is not duplicated? You could make the original implementation figure out the outputUrl and call |
Also, it's a small detail but on the header you should add the specifiers to tell if an argument is optional or not. That way it integrates nicely with Swift :). Thank you so much! |
Quick fix until pull request is open:
|
# Conflicts: # Library/Sources/SCAssetExportSession.m
CIContext was nil, now its not.