Refactor 'CMarkup::Format' and 'CMarkup::x_TextToDoc' #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push2312 observed in THIS issue that building with CMake MinGW Makefiles produces errors (Microsoft-specific
strcpy_s
and_vsnprintf_s
functions not being "declared in this scope").cktii observed in THIS issue that
CMarkup::x_TextToDoc
contains a vulnerability.This PR refactors
CMarkup::Format
to resolve those issues and includes minor improvements:_vscprintf
withvsnprintf
for buffer size calculation on non-MSVC platforms, enhancing cross-platform compatibilityva_copy
to safely duplicate theva_list
when determining buffer size, preventing potential undefined behavior from double evaluationx_TextToDoc
to usestd::string