New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vulnerability In 'x_TextToDoc' Function #50

Closed

OliverGlandberger wants to merge 2 commits into master from vulnerability_fix_markup_cpp

Contributor

OliverGlandberger commented Nov 8, 2024 •

edited

Loading

It was pointed out by cktii in THIS issue that CMarkup::x_TextToDoc contains a vulnerability.

This PR fixes that issue by modifying the code to utilize std::string.

NOTE: This PR also solves a problem described in THIS issue.

OliverGlandberger added 2 commits

November 8, 2024 12:16


          Update 'x_TextToDoc' to remove heap buffer overflow vulnerability.

18e655e


          Reintroduce accidentally removed 'const' from function.

856d283

OliverGlandberger mentioned this pull request

Refactor 'CMarkup::Format' and 'CMarkup::x_TextToDoc' #51

Open

Contributor Author

OliverGlandberger commented Nov 15, 2024

Added this code to the other existing PR HERE, closing this.

OliverGlandberger closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet