Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #806 (if results table order changed, hide/show details hover over broken) #807

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Fix for #806 (if results table order changed, hide/show details hover over broken) #807

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59e2667
Fix for #806
volkan-aslan Apr 9, 2024
353d86e
Adding test for verification of collapsed class if it is in correct c…
volkan-aslan Apr 11, 2024
8837790
missing '.' added
volkan-aslan Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pytest_html/scripts/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ const dom = {
}

if (collapsed) {
resultBody.querySelector('.collapsible > td')?.classList.add('collapsed')
resultBody.querySelector('.collapsible > col-result')?.classList.add('collapsed')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the code infront of my right now as I'm on vacation, but are we sure this will uniquely identify the column?

I ask because IIRC other things can have at least the ".collapsible" class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is but better if you can double check when you return from vacation.
Thanks.

resultBody.querySelector('.extras-row').classList.add('hidden')
} else {
resultBody.querySelector('.collapsible > td')?.classList.remove('collapsed')
resultBody.querySelector('.collapsible > col-result')?.classList.remove('collapsed')
}

const media = []
Expand Down
Loading