Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #806 (if results table order changed, hide/show details hover over broken) #807

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Fix for #806 (if results table order changed, hide/show details hover over broken) #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59e2667
Fix for #806
volkan-aslan Apr 9, 2024
353d86e
Adding test for verification of collapsed class if it is in correct c…
volkan-aslan Apr 11, 2024
8837790
missing '.' added
volkan-aslan Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pytest_html/scripts/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ const dom = {
}

if (collapsed) {
resultBody.querySelector('.collapsible > td')?.classList.add('collapsed')
resultBody.querySelector('.collapsible > .col-result')?.classList.add('collapsed')
resultBody.querySelector('.extras-row').classList.add('hidden')
} else {
resultBody.querySelector('.collapsible > td')?.classList.remove('collapsed')
resultBody.querySelector('.collapsible > .col-result')?.classList.remove('collapsed')
}

const media = []
Expand Down
18 changes: 18 additions & 0 deletions testing/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,24 @@ def test_CCC():
for row, expected in zip(result, order):
assert_that(row.string).contains(expected)

def test_collapsed_class_when_results_table_order_changed(self, pytester):
pytester.makeconftest(
"""
def pytest_html_results_table_header(cells):
cells.append(cells.pop(0))
def pytest_html_results_table_row(report, cells):
cells.append(cells.pop(0))
"""
)
pytester.makepyfile("def test_pass(): pass")
page = run(pytester)
assert_results(page, passed=1)

assert_that(
get_text(page, "#results-table td[class='col-result collapsed']")
).is_true()


class TestLogCapturing:
LOG_LINE_REGEX = r"\s+this is {}"
Expand Down
Loading