Bump pymc dependency #1269

ricardoV94 · 2024-12-13T10:25:04Z

Closes #726

📚 Documentation preview 📚: https://pymc-marketing--1269.org.readthedocs.build/en/1269/

juanitorduz · 2024-12-13T10:31:14Z

Thanks for this one!

codecov · 2024-12-13T10:48:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9684821) to head (50978df).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   95.34%   95.29%   -0.06%     
==========================================
  Files          47       47              
  Lines        4943     4889      -54     
==========================================
- Hits         4713     4659      -54     
  Misses        230      230

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juanitorduz · 2024-12-13T10:52:25Z

There are just two failing tests (yay!)

FAILED tests/clv/models/test_gamma_gamma.py::TestGammaGammaModel::test_spend[True]
FAILED tests/test_model_builder.py::test_fit_random_seed_reproducibility[rng]

wd60622 · 2024-12-13T12:01:40Z

Closes #726

tests/test_mlflow.py

ricardoV94 · 2024-12-13T15:27:29Z

FAILED tests/clv/models/test_gamma_gamma.py::TestGammaGammaModel::test_spend[True]

AFAICT it's a seed problem. standard deviation is similar to old version, and I could get it to fail then if I changed the seed. Making tolerance higher

ricardoV94 · 2024-12-13T15:45:04Z

The second failure seems to be a regression in PyMC regarding seeding with generators: pymc-devs/pymc#7612

ricardoV94 · 2024-12-13T16:02:55Z

Thanks for this one!

Very specific appreciation noted :D

juanitorduz · 2024-12-13T18:14:10Z

The second failure seems to be a regression in PyMC regarding seeding with generators: pymc-devs/pymc#7612

So, do we need to wait for this to be fixed in PyMC before merging this one? Or shall we skip this test (in the meantime)?

ricardoV94 · 2024-12-13T18:44:33Z

This is buggy behavior so I would wait until the next release with the fix

PabloRoque · 2024-12-16T14:14:34Z

Agua de Mayo

ColtAllen · 2024-12-16T18:45:59Z

This is buggy behavior so I would wait until the next release with the fix

The next pymc-marketing release, or next pymc release?

ricardoV94 · 2024-12-16T19:03:36Z

Agua de Mayo

What does that mean? 🤔

ricardoV94 · 2024-12-16T19:03:52Z

This is buggy behavior so I would wait until the next release with the fix

The next pymc-marketing release, or next pymc release?

Next pymc release

PabloRoque · 2024-12-16T20:42:16Z

What does that mean? 🤔

Agua de Mayo may be translated as something is godsend.

Context: I got a new Apple Silicon machine last week. Making blas work has been painful. I made it work following this release of pytensor you mentioned somewhere else.

However that version is not supported in the pymc-marketing library. So indeed this PR is godsend to me.

aseyboldt · 2024-12-20T14:34:16Z

@wd60622 Is there anything holding this back?

wd60622 · 2024-12-20T14:37:13Z

@wd60622 Is there anything holding this back?

@ricardoV94 mentioned non deterministic behavior with pymc version

ricardoV94 · 2025-01-07T20:56:45Z

Hopefully it will work with https://github.com/pymc-devs/pymc/releases/tag/v5.20.0

juanitorduz · 2025-01-07T21:03:05Z

Yay 🙌!

juanitorduz · 2025-01-08T10:24:20Z

environment.yml

@@ -15,7 +15,7 @@ dependencies:
 - pydantic
 - preliz
 # NOTE: Keep minimum pymc version in sync with ci.yml `OLDEST_PYMC_VERSION`
- pymc>=5.12.0,<5.16.0
+- pymc>=5.19.1


@ricardoV94 so this should be pymc>=5.20 ?

Yes I didn't update yet

Can you remove this:

pymc-marketing/pymc_marketing/mlflow.py

Lines 166 to 175 in 9684821

def _backwards_compatiable_data_vars(model: Model) -> list[TensorVariable]:

# TODO: Remove with PyMC update

non_data = (

model.observed_RVs + model.free_RVs + model.deterministics + model.potentials

)

vars = {

key: value for key, value in model.named_vars.items() if value not in non_data

}

return list(vars.values())

I already removed it?

Ah sorry I thought it was the mlflow from the requirements. Will do

Sorry commented in wrong thread. Not related but was a backwards compat in the mlflow module

* Add BGNBD distribution and BGNBD Random Variable * Add BGNBD excel test * Remove logp in terms of Potential * Rename BGNBD -> BetaGeoNBD * Add logp and test matching lifetimes * Add logp param.type.ndim > 1. Add logp pt.switch. Related tests * Add test_bg_nbd_sample_prior * Add _distribution_new_customers and related test. Rename population_dropout|purchase_rate as dropout|purchase_rate to consolidate naming among models * Adjust test_model_repr expected result to BetaGeoNBD instead of BGNBD * Improve distribution_new_customer, distribution_new_customer_purchase_rate. Introduce distribution_new_customer_recency_frequency. Improve tests * Revert @pytest.mark.slow to in test_model_convergence * Revert distribution changes related to #1269 * Revert more changes related to #1269 * Revert BetaGeoBetaBinomRV changes * Revert ParetoNBDRV changes * Docstring cleanup * Revert changes in ContContract dist * Clean ContContract changes * Revert deletion _supp_shape_from_params * Remove commented chunk on fit_result. Opted for data to standardize with other CLV models * BetaGeoNBDRV as pre-#1269 definition * Fix test_numerically_stable_logp * Overrride ModifiedBetaGeoModel.distribution_new_customer method * Modify test_bg_nbd tensor parametrization to only vectors in test_bg_nbd. Passing param.type.ndim > 1 now raises NotImplementedError * Silence mypy in 2 lines * Adapt BetaGeoNBDRV to #1269 * Fix test_clv_fit_mcmc * Modify sim_data to reflect the beta-distributed dropout process * Add reference to BetaGeoNBD * Delete _logp * Delete commented weights param in test_bg_nbd * Ammend BetaGeoNBD docstring * Fix BetaGeoNBD math * Fix test_posterior_distributions to include dropout distributions * Fix #NUM! docstring * Tweak sim_data * Add co-author. Co-authored-by: Colt Allen <[email protected]> --------- Co-authored-by: Colt Allen <[email protected]>

github-actions bot added CLV tests labels Dec 13, 2024

juanitorduz mentioned this pull request Dec 13, 2024

Bump minimal dependency PyMC >= 5.16 #1241

Closed

juanitorduz added enhancement New feature or request maintenance priority: high dependencies labels Dec 13, 2024

wd60622 reviewed Dec 13, 2024

View reviewed changes

tests/test_mlflow.py Outdated Show resolved Hide resolved

ricardoV94 changed the title ~~Bump pymc dep~~ Bump pymc dependency Dec 13, 2024

ricardoV94 mentioned this pull request Dec 13, 2024

Sampling with generators as seeding no longer deterministic pymc-devs/pymc#7612

Closed

ricardoV94 force-pushed the bump_pymc_dep branch 2 times, most recently from 7511d19 to 2a4b943 Compare December 13, 2024 15:57

ColtAllen mentioned this pull request Dec 20, 2024

Modified Beta Geometric model #1301

Merged

13 tasks

ColtAllen mentioned this pull request Dec 20, 2024

Installation not working (on macOS with M1) #1305

Closed

ColtAllen mentioned this pull request Dec 27, 2024

Introduce BetaGeoNBD Random Variable #1317

Merged

14 tasks

PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025

Revert distribution changes related to pymc-labs#1269

256b607

PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025

Revert more changes related to pymc-labs#1269

5bf47d7

PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025

BetaGeoNBDRV as pre-pymc-labs#1269 definition

4c46ae8

ricardoV94 force-pushed the bump_pymc_dep branch from e69031b to 814dbd6 Compare January 7, 2025 18:38

juanitorduz reviewed Jan 8, 2025

View reviewed changes

ricardoV94 force-pushed the bump_pymc_dep branch from 814dbd6 to c585ee2 Compare January 8, 2025 16:09

github-actions bot added the mlflow label Jan 8, 2025

ricardoV94 marked this pull request as ready for review January 8, 2025 16:10

ricardoV94 force-pushed the bump_pymc_dep branch from c585ee2 to c6cb972 Compare January 8, 2025 16:11

Bump PyMC dependency

35079bb

ricardoV94 force-pushed the bump_pymc_dep branch from c6cb972 to 35079bb Compare January 8, 2025 16:12

juanitorduz added the major API breaking changes label Jan 8, 2025

Merge branch 'main' into bump_pymc_dep

50978df

juanitorduz approved these changes Jan 8, 2025

View reviewed changes

juanitorduz merged commit 8541ca5 into pymc-labs:main Jan 8, 2025
19 of 20 checks passed

PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 9, 2025

Adapt BetaGeoNBDRV to pymc-labs#1269

bcc8fa7

ricardoV94 deleted the bump_pymc_dep branch January 9, 2025 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump pymc dependency #1269

Bump pymc dependency #1269

ricardoV94 commented Dec 13, 2024 •

edited

Loading

juanitorduz commented Dec 13, 2024

codecov bot commented Dec 13, 2024 •

edited

Loading

juanitorduz commented Dec 13, 2024

wd60622 commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024 •

edited

Loading

ricardoV94 commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024

juanitorduz commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024

PabloRoque commented Dec 16, 2024

ColtAllen commented Dec 16, 2024

ricardoV94 commented Dec 16, 2024

ricardoV94 commented Dec 16, 2024

PabloRoque commented Dec 16, 2024

aseyboldt commented Dec 20, 2024

wd60622 commented Dec 20, 2024

ricardoV94 commented Jan 7, 2025

juanitorduz commented Jan 7, 2025

juanitorduz Jan 8, 2025

ricardoV94 Jan 8, 2025

wd60622 Jan 8, 2025

ricardoV94 Jan 8, 2025

ricardoV94 Jan 8, 2025

wd60622 Jan 8, 2025

	def _backwards_compatiable_data_vars(model: Model) -> list[TensorVariable]:
	# TODO: Remove with PyMC update
	non_data = (
	model.observed_RVs + model.free_RVs + model.deterministics + model.potentials
	)
	vars = {
	key: value for key, value in model.named_vars.items() if value not in non_data
	}

	return list(vars.values())

Bump pymc dependency #1269

Bump pymc dependency #1269

Conversation

ricardoV94 commented Dec 13, 2024 • edited Loading

juanitorduz commented Dec 13, 2024

codecov bot commented Dec 13, 2024 • edited Loading

Codecov Report

juanitorduz commented Dec 13, 2024

wd60622 commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024 • edited Loading

ricardoV94 commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024

juanitorduz commented Dec 13, 2024

ricardoV94 commented Dec 13, 2024

PabloRoque commented Dec 16, 2024

ColtAllen commented Dec 16, 2024

ricardoV94 commented Dec 16, 2024

ricardoV94 commented Dec 16, 2024

PabloRoque commented Dec 16, 2024

aseyboldt commented Dec 20, 2024

wd60622 commented Dec 20, 2024

ricardoV94 commented Jan 7, 2025

juanitorduz commented Jan 7, 2025

juanitorduz Jan 8, 2025

Choose a reason for hiding this comment

ricardoV94 Jan 8, 2025

Choose a reason for hiding this comment

wd60622 Jan 8, 2025

Choose a reason for hiding this comment

ricardoV94 Jan 8, 2025

Choose a reason for hiding this comment

ricardoV94 Jan 8, 2025

Choose a reason for hiding this comment

wd60622 Jan 8, 2025

Choose a reason for hiding this comment

ricardoV94 commented Dec 13, 2024 •

edited

Loading

codecov bot commented Dec 13, 2024 •

edited

Loading

ricardoV94 commented Dec 13, 2024 •

edited

Loading