Commits on Jul 12, 2024

1. Remove all patches related to tagsAll …

   This PR removes all patches related to the `tagsAll` implementation and
   restores the upstream implementation. The new (newer than our hack) upstream tagging
   implementation utilizes a combination of storing `defaultTags` in
   context and utilizing a [provider interceptor](https://github.com/hashicorp/terraform-provider-aws/blob/3b6772b0864505f9232f737e3d72d80f14043609/internal/provider/intercept.go)
   
   - Updates the s3legacy tagging implementation to match the s3
     implementation (via patch)
   - Updates the `applyTags` `PreCheckCallback` to only remove "__defaults"
     items from tags (see #4204)
   
   In the current implementation there is a breaking change. Previously
   `tags` always equaled `tagsAll` so you could reference the `tags` output
   value to get all the tags on the resource. Now these are two separate
   fields and you would need to reference the `tagsAll` output to get all
   the tags. I'm not sure how many people will reference the `tags` output,
   but if we wanted to avoid this breaking change until the next major
   version we could utilize the `TransformOutputs` callback to always set
   `tags=tagsAll`.

   

   corymhall committed Jul 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for be88c5a
   • Browse repository at this point

   Copy the full SHA

   be88c5a View commit details

   Browse the repository at this point in the history