Remove all patches related to tagsAll #4219
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all patches related to the `tagsAll` implementation and restores the upstream implementation. The new (newer than our hack) upstream tagging implementation utilizes a combination of storing `defaultTags` in context and utilizing a [provider interceptor](https://github.com/hashicorp/terraform-provider-aws/blob/3b6772b0864505f9232f737e3d72d80f14043609/internal/provider/intercept.go) - Updates the s3legacy tagging implementation to match the s3 implementation (via patch) - Updates the `applyTags` `PreCheckCallback` to only remove "__defaults" items from tags (see #4204) In the current implementation there is a breaking change. Previously `tags` always equaled `tagsAll` so you could reference the `tags` output value to get all the tags on the resource. Now these are two separate fields and you would need to reference the `tagsAll` output to get all the tags. I'm not sure how many people will reference the `tags` output, but if we wanted to avoid this breaking change until the next major version we could utilize the `TransformOutputs` callback to always set `tags=tagsAll`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all patches related to the
tagsAllimplementation and restores the upstream implementation. The new (newer than our hack) upstream tagging implementation utilizes a combination of storingdefaultTagsin context and utilizing a provider interceptorapplyTagsPreCheckCallbackto only remove "__defaults" items from tags (see Error on refresh after import for pf based resources with tags #4204)In the current implementation there is a breaking change. Previously
tagsalways equaledtagsAllso you could reference thetagsoutput value to get all the tags on the resource. Now these are two separate fields and you would need to reference thetagsAlloutput to get all the tags. I'm not sure how many people will reference thetagsoutput, but if we wanted to avoid this breaking change until the next major version we could utilize theTransformOutputscallback to always settags=tagsAll.Remaining Issues
PlanResourceChangeneeds to be enabledPlanResourceChangedoesn't work when trying to import legacy bucket.