Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade upstream v5.14.0 #2761

Closed
wants to merge 0 commits into from
Closed

Upgrade upstream v5.14.0 #2761

wants to merge 0 commits into from

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 30, 2023

Fixes #2712
Fixes #2703
Fixes #2702
Fixes #2693

@iwahbe iwahbe requested review from t0yv0 and a team August 30, 2023 16:23
@iwahbe iwahbe self-assigned this Aug 30, 2023
@iwahbe iwahbe requested a review from lukehoban August 30, 2023 16:23
@t0yv0 t0yv0 mentioned this pull request Aug 30, 2023
Closed
4 tasks
@iwahbe iwahbe mentioned this pull request Aug 30, 2023
Closed
@github-actions
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 8 breaking changes:

Functions

  • "aws:dms/getEndpoint:getEndpoint": inputs:
    • 🟡 "elasticsearchSettings" missing input "elasticsearchSettings"
    • 🟡 "extraConnectionAttributes" missing input "extraConnectionAttributes"
    • 🟡 "kafkaSettings" missing input "kafkaSettings"
    • 🟡 "mongodbSettings" missing input "mongodbSettings"

Types

  • 🟢 "aws:ec2/getInstanceMetadataOption:getInstanceMetadataOption": required: "httpProtocolIpv6" property has changed to Required
  • 🟡 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettings": properties: "dvbTdtSettings" missing
  • 🔴 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings" missing
  • 🟡 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsEmbeddedSourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsEmbeddedSourceSettings": properties: "source608TrackNumber" missing

New resources:

  • cloudfront/continuousDeploymentPolicy.ContinuousDeploymentPolicy
  • codecatalyst/devEnvironment.DevEnvironment
  • codecatalyst/project.Project
  • codecatalyst/sourceRepository.SourceRepository
  • datasync/locationAzureBlob.LocationAzureBlob
  • datasync/locationFsxOntapFileSystem.LocationFsxOntapFileSystem
  • msk/clusterPolicy.ClusterPolicy
  • msk/vpcConnection.VpcConnection
  • opensearch/vpcEndpoint.VpcEndpoint
  • ram/sharingWithOrganization.SharingWithOrganization

New functions:

  • codecatalyst/getDevEnvironment.getDevEnvironment
  • ec2transitgateway/getRouteTableRoutes.getRouteTableRoutes
  • msk/getVpcConnection.getVpcConnection

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe mentioned this pull request Aug 30, 2023
Merged
t0yv0
t0yv0 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs some gen code mainten

@iwahbe iwahbe closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@iwahbe @t0yv0 @lukehoban