-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined: Bridge Update & #2761 & #2681 #2763
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
Aug 30, 2023
@@ -22745,14 +22908,13 @@ | |||
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsAncillarySourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsAncillarySourceSettings": { | |||
"sourceAncillaryChannelNumber": "source_ancillary_channel_number" | |||
}, | |||
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings": { | |||
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbSubSourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbSubSourceSettings": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my word.
It think the bridge update needs another round of make tfgen otherwise schema examples are not corrected. |
Does the PR have any schema changes?Does the PR have any schema changes?Found 8 breaking changes: Functions
Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
|
t0yv0
approved these changes
Aug 30, 2023
I think we can close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #2761, #2681 and a bridge update into 1 PR.
We are combining PRs to reduce the CI time needed to make a release.