Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined: Bridge Update & #2761 & #2681 #2763

Closed
wants to merge 12 commits into from
Closed

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 30, 2023

This PR combines #2761, #2681 and a bridge update into 1 PR.

We are combining PRs to reduce the CI time needed to make a release.

@iwahbe iwahbe requested a review from t0yv0 August 30, 2023 16:46
@@ -22745,14 +22908,13 @@
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsAncillarySourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsAncillarySourceSettings": {
"sourceAncillaryChannelNumber": "source_ancillary_channel_number"
},
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings": {
"aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbSubSourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbSubSourceSettings": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my word.

@t0yv0
Copy link
Member

t0yv0 commented Aug 30, 2023

It think the bridge update needs another round of make tfgen otherwise schema examples are not corrected.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 8 breaking changes:

Functions

  • "aws:dms/getEndpoint:getEndpoint": inputs:
    • 🟡 "elasticsearchSettings" missing input "elasticsearchSettings"
    • 🟡 "extraConnectionAttributes" missing input "extraConnectionAttributes"
    • 🟡 "kafkaSettings" missing input "kafkaSettings"
    • 🟡 "mongodbSettings" missing input "mongodbSettings"

Types

  • 🟢 "aws:ec2/getInstanceMetadataOption:getInstanceMetadataOption": required: "httpProtocolIpv6" property has changed to Required
  • 🟡 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettings": properties: "dvbTdtSettings" missing
  • 🔴 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsDvbTdtSettings" missing
  • 🟡 "aws:medialive/ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsEmbeddedSourceSettings:ChannelInputAttachmentInputSettingsCaptionSelectorSelectorSettingsEmbeddedSourceSettings": properties: "source608TrackNumber" missing

New resources:

  • cloudfront/continuousDeploymentPolicy.ContinuousDeploymentPolicy
  • codecatalyst/devEnvironment.DevEnvironment
  • codecatalyst/project.Project
  • codecatalyst/sourceRepository.SourceRepository
  • datasync/locationAzureBlob.LocationAzureBlob
  • datasync/locationFsxOntapFileSystem.LocationFsxOntapFileSystem
  • msk/clusterPolicy.ClusterPolicy
  • msk/vpcConnection.VpcConnection
  • opensearch/vpcEndpoint.VpcEndpoint
  • ram/sharingWithOrganization.SharingWithOrganization

New functions:

  • codecatalyst/getDevEnvironment.getDevEnvironment
  • ec2transitgateway/getRouteTableRoutes.getRouteTableRoutes
  • msk/getVpcConnection.getVpcConnection

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member

t0yv0 commented Aug 30, 2023

## Import

Using `pulumi import`, import certificates using their ARN. For example:

```sh
 $ pulumi import aws:acm/certificate:Certificate cert arn:aws:acm:eu-central-1:123456789012:certificate/7e7a28d2-163f-4b8f-b9cd-822f96c08d6a

Import sections look fixed! 

@t0yv0 t0yv0 self-requested a review August 30, 2023 17:38
@iwahbe iwahbe mentioned this pull request Aug 30, 2023
@t0yv0
Copy link
Member

t0yv0 commented Sep 7, 2023

I think we can close this?

@iwahbe iwahbe closed this Sep 7, 2023
@iwahbe iwahbe deleted the iwahbe/update-bridge branch September 7, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants