Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto-aliasing #2681

Closed
wants to merge 1 commit into from

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 8, 2023

Now that we have a stable release and no longer intend to make backwards incompatible changes, we turn on auto-aliasing. This prevents several classes of breaking changes from effecting our users.

Resolves #2691

@iwahbe iwahbe self-assigned this Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@@ -1965,18 +1965,6 @@ func Provider() *tfbridge.ProviderInfo {
},
},
// ECS for Kubernetes
"aws_eks_cluster": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because explicit configuration is no longer necessary (see TODO on L1974). Since this code no longer provides a benefit, I have removed it.

@t0yv0 t0yv0 self-requested a review August 9, 2023 14:09
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be good, should we wait a bit after 6.x release to push the through? It can wait a little right?

@t0yv0 t0yv0 mentioned this pull request Aug 30, 2023
4 tasks
@iwahbe iwahbe force-pushed the iwahbe/enable-auto-aliasing branch from f2e8d9d to f3d04ef Compare August 30, 2023 16:34
@iwahbe iwahbe changed the base branch from master to iwahbe/upstream-v5.14.0 August 30, 2023 16:41
@iwahbe
Copy link
Member Author

iwahbe commented Aug 31, 2023

Merged as part of #2766

@iwahbe iwahbe closed this Aug 31, 2023
@iwahbe iwahbe deleted the iwahbe/enable-auto-aliasing branch August 31, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable auto-aliasing
2 participants