-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable auto-aliasing #2681
Enable auto-aliasing #2681
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
@@ -1965,18 +1965,6 @@ func Provider() *tfbridge.ProviderInfo { | |||
}, | |||
}, | |||
// ECS for Kubernetes | |||
"aws_eks_cluster": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because explicit configuration is no longer necessary (see TODO on L1974). Since this code no longer provides a benefit, I have removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be good, should we wait a bit after 6.x release to push the through? It can wait a little right?
f2e8d9d
to
f3d04ef
Compare
f3d04ef
to
7c1c55e
Compare
Merged as part of #2766 |
Now that we have a stable release and no longer intend to make backwards incompatible changes, we turn on auto-aliasing. This prevents several classes of breaking changes from effecting our users.
Resolves #2691