-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved questions no_results_found message #9555
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9555 +/- ##
=======================================
Coverage ? 79.69%
=======================================
Files ? 98
Lines ? 5944
Branches ? 0
=======================================
Hits ? 4737
Misses ? 1207
Partials ? 0 |
1b421cb
to
14b435a
Compare
14b435a
to
5cddecb
Compare
Code Climate has analyzed commit 5cddecb and detected 0 issues on this pull request. View more on Code Climate. |
Hey @TildaDares I have created a break out issue for this here #9556 and I will link it to this...please do the same for any other subtasks you would like to work on so that we can keep the parent issue opened until all the issues are fixed. Thanks a lot for working on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉 thanks again
Fixes #9556
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!