Improved questions no_results_found message

publiclab · Apr 23, 2021 · 1b421cb · 1b421cb
1 parent 2c0a624
commit 1b421cb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/app/views/tag/show/_tab_content.html.erb b/app/views/tag/show/_tab_content.html.erb
@@ -18,13 +18,16 @@
   <% if @node_type == "questions" %>
     <div class="tab-pane active" id="questions">
       <div id="questions-tab">
-
-        <div class="tab-content">
-          <div id="asked-content">
-            <%= render partial: "questions/new_question" %>
+        <% if @questions.nil? || @questions.length == 0 %>
+          <p><%= raw translation('tag.show.no_questions_results_found', tag: params[:id]) %></p>
+          <p>Or try searching: <a href="/search/<%= params[:id] %>"><%= params[:id] %></a></p>
+        <% else %>
+          <div class="tab-content">
+            <div id="asked-content">
+              <%= render partial: "questions/new_question" %>
+            </div>
           </div>
-        </div>
-
+        <% end %>
       </div>
     </div>
   <% end %>

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -402,6 +402,7 @@ en:
       unfollow: "Click to unfollow"
       follow: "Follow"
       no_results: "No results found; try searching for '%{search}'"
+      no_questions_results_found: "Hi! No Questions have this tag <span>&#x1F937</span>, try checking the <b>Research Notes</b> or <b>Wikis</b> tabs on this page."
       no_recent_posts: "There are no recent posts"
       advanced_search: "Or try an <a href='%{url}'>advanced search</a>"
       by: "by"