Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #8542 Removed banned users from followers/following list #9300

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

17sushmita
Copy link
Member

@17sushmita 17sushmita commented Mar 14, 2021

Fixes part of #9319

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@17sushmita 17sushmita requested a review from a team as a code owner March 14, 2021 15:02
@gitpod-io
Copy link

gitpod-io bot commented Mar 14, 2021

app/controllers/users_controller.rb Outdated Show resolved Hide resolved
app/controllers/users_controller.rb Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@56139e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9300   +/-   ##
=======================================
  Coverage        ?   50.14%           
=======================================
  Files           ?       98           
  Lines           ?     6033           
  Branches        ?        0           
=======================================
  Hits            ?     3025           
  Misses          ?     3008           
  Partials        ?        0           

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2021

Code Climate has analyzed commit 8fe4013 and detected 0 issues on this pull request.

View more on Code Climate.

@17sushmita
Copy link
Member Author

@cesswairimu @jywarren Please review the PR.

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@cesswairimu cesswairimu merged commit 7061c1d into publiclab:main Mar 16, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…ing list (publiclab#9300)

* Fix part of publiclab#8542 Removed banned users from followers/following list

* fixed codeclimate issue on the previous commit
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…ing list (publiclab#9300)

* Fix part of publiclab#8542 Removed banned users from followers/following list

* fixed codeclimate issue on the previous commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants