-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followers/following page: avatar and grid #9315
Followers/following page: avatar and grid #9315
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9315 +/- ##
=======================================
Coverage ? 49.85%
=======================================
Files ? 98
Lines ? 6033
Branches ? 0
=======================================
Hits ? 3008
Misses ? 3025
Partials ? 0 |
@cesswairimu @jywarren Could you please check why codeclimate hasn't finished analyzing yet and also review the PR? |
Code Climate has analyzed commit a4e86fc and detected 0 issues on this pull request. View more on Code Climate. |
Hi again, I will try and reopen to see if the test passes kindly refer to #9301 (comment) and create an issue for the changes you did here...this is going great, thanks a lot for your help with these ❤️ |
Sure, I'll create an issue for this. Thank You!! 😃 |
I really love this, nice design and well coded! Doing a quick review and we'll hopefully merge today! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done!!!
* Fix part of publiclab#8542 Enhance Followers/Following Page * Refactured previous commit changes
* Fix part of publiclab#8542 Enhance Followers/Following Page * Refactured previous commit changes
Fixes #9320
rake test
@publiclab/reviewers
for help, in a comment below**test_user_2 is banned. Merging PR #9300 will remove banned users.
**Merging PR #9301 will add Follower/Following count to their respective tabs
Before
After