Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followers/following page: avatar and grid #9315

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

17sushmita
Copy link
Member

@17sushmita 17sushmita commented Mar 15, 2021

Fixes #9320

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

**test_user_2 is banned. Merging PR #9300 will remove banned users.
**Merging PR #9301 will add Follower/Following count to their respective tabs
Before
image

After
image
image

@17sushmita 17sushmita requested a review from a team as a code owner March 15, 2021 18:32
@gitpod-io
Copy link

gitpod-io bot commented Mar 15, 2021

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@56139e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9315   +/-   ##
=======================================
  Coverage        ?   49.85%           
=======================================
  Files           ?       98           
  Lines           ?     6033           
  Branches        ?        0           
=======================================
  Hits            ?     3008           
  Misses          ?     3025           
  Partials        ?        0           

@17sushmita
Copy link
Member Author

@cesswairimu @jywarren Could you please check why codeclimate hasn't finished analyzing yet and also review the PR?

@codeclimate
Copy link

codeclimate bot commented Mar 16, 2021

Code Climate has analyzed commit a4e86fc and detected 0 issues on this pull request.

View more on Code Climate.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Mar 16, 2021

Hi again, I will try and reopen to see if the test passes kindly refer to #9301 (comment) and create an issue for the changes you did here...this is going great, thanks a lot for your help with these ❤️

@cesswairimu cesswairimu reopened this Mar 16, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 16, 2021

@17sushmita
Copy link
Member Author

Hi again, I will try and reopen to see if the test passes kindly refer to #9301 (comment) and create an issue for the changes you did here...this is going great, thanks a lot for your help with these

Sure, I'll create an issue for this. Thank You!! 😃

@cesswairimu cesswairimu changed the title Fix part of #8542 Enhance Followers/Following Page Followers/following page: avatar and grid Mar 16, 2021
@jywarren
Copy link
Member

I really love this, nice design and well coded! Doing a quick review and we'll hopefully merge today! 🎉

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!!!

@jywarren jywarren merged commit 0f4e8e8 into publiclab:main Mar 16, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Fix part of publiclab#8542 Enhance Followers/Following Page

* Refactured previous commit changes
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Fix part of publiclab#8542 Enhance Followers/Following Page

* Refactured previous commit changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followers/Following Page: Enhance Follower/following list
3 participants