Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update pd_grid analysis.ipynb to use new spaces #2553

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Dec 19, 2024

This updates the notebook for the PD grid example to correctly reflect the use of new style spaces. In passing, this also now nicely illustrates how the default matplotlib space drawing stuff can be used.

Closes #2552

@quaquel quaquel added the bug Release notes label label Dec 19, 2024
@quaquel quaquel requested a review from EwoutH December 19, 2024 07:49
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit f751651 into projectmesa:main Jan 1, 2025
7 of 9 checks passed
@quaquel quaquel deleted the pd_analysis branch January 1, 2025 13:48
@EwoutH
Copy link
Member

EwoutH commented Jan 3, 2025

@quaquel this PR seems to have broken the codespell check in pre-commit. Could you check?

@quaquel
Copy link
Member Author

quaquel commented Jan 3, 2025

I would not know how. It only changes a notebook, and the notebook content seems fine to me.

@EwoutH EwoutH changed the title Update pd_grid example analysis.ipynb examples: Update pd_grid analysis.ipynb to use new spaces Jan 4, 2025
@EwoutH EwoutH added example Changes the examples or adds to them. and removed bug Release notes label labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Changes the examples or adds to them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Demographic Prisoner's Dilemma Activation Schedule
3 participants