Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model name in visualization tutorial #2591

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

Sahil-Chhoker
Copy link
Contributor

Summary

Updated the model name to a more descriptive name in visualization tutorial

Bug / Issue

fix #2589

Implementation

Changed model1 and model to money_model

Testing

Tested by running the model, observed no errors.

Copy link
Member

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

The pre-commit failure is a bit weird. Curious where it originated from, doesn't seem to be by this PR.

@quaquel
Copy link
Member

quaquel commented Jan 3, 2025

No its been there for the last two weeks or so, another rabbit hole if I have time.

@EwoutH
Copy link
Member

EwoutH commented Jan 3, 2025

I think it's #2553.

@EwoutH EwoutH merged commit 2439a1f into projectmesa:main Jan 3, 2025
10 of 11 checks passed
@EwoutH EwoutH added the docs Release notes label label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect variable reference in SolaraViz example in visualization_tutorial.ipynb and related documentation
3 participants