Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording on search results info text when no search term is entered #30442

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change wording on search results info text when no search term is entered #30442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c937a3
change wording when song select search box is empty.
jhk2601 Oct 28, 2024
540601c
change phrasing to match stable
jhk2601 Oct 28, 2024
42d03c7
moved comment
jhk2601 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions osu.Game/Screens/Select/SongSelect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,10 +957,18 @@ private void carouselBeatmapsLoaded()

private void updateVisibleBeatmapCount()
{
// Intentionally not localised until we have proper support for this (see https://github.com/ppy/osu-framework/pull/4918
// but also in this case we want support for formatting a number within a string).
int carouselCountDisplayed = Carousel.CountDisplayed;
FilterControl.InformationalText = carouselCountDisplayed != 1 ? $"{carouselCountDisplayed:#,0} matches" : $"{carouselCountDisplayed:#,0} match";

if (FilterControl.CurrentTextSearch.Value == string.Empty)
{
FilterControl.InformationalText = $"{carouselCountDisplayed} beatmaps available";
Copy link
Member

@Joehuu Joehuu Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings back the terminology conflict in #23000 (comment) (first run setup counting "beatmaps" and song select counting "beatmap difficulties", which was maybe too long a label that it had to be changed to be ambiguous).

Can be X available, but that looks wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, if anything shouldn't the first run import text be changed? Either changing the text to say "mapsets" or changing the number to match stable "beatmaps" would work. The disparity between the import number and the number I got in the stable dialogue is quite confusing irrespective of this change so a change there would be beneficial anyway.
image

Copy link
Member

@Joehuu Joehuu Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://osu.ppy.sh/wiki/en/Beatmap, stable wording is wrong. Also, the term "mapsets" is rarely used in the wiki.

I just want consistency in wiki, lazer/stable, and web.

Edit: To answer your question, users may want to see the "beatmap" (wiki definition) number, so I don't think that should be changed.

}
else
{
// Intentionally not localised until we have proper support for this (see https://github.com/ppy/osu-framework/pull/4918
// but also in this case we want support for formatting a number within a string).
FilterControl.InformationalText = carouselCountDisplayed != 1 ? $"{carouselCountDisplayed:#,0} matches" : $"{carouselCountDisplayed:#,0} match";
}
}

private bool boundLocalBindables;
Expand Down
Loading