Change wording on search results info text when no search term is entered #30442
Conversation
|
Comparison images for reference, top is post PR bottom is live
|
|
|
||
| if (FilterControl.CurrentTextSearch.Value == string.Empty) | ||
| { | ||
| FilterControl.InformationalText = $"{carouselCountDisplayed} beatmaps available"; |
There was a problem hiding this comment.
This brings back the terminology conflict in #23000 (comment) (first run setup counting "beatmaps" and song select counting "beatmap difficulties", which was maybe too long a label that it had to be changed to be ambiguous).
Can be X available, but that looks wrong.
There was a problem hiding this comment.
Ah I see, if anything shouldn't the first run import text be changed? Either changing the text to say "mapsets" or changing the number to match stable "beatmaps" would work. The disparity between the import number and the number I got in the stable dialogue is quite confusing irrespective of this change so a change there would be beneficial anyway.
There was a problem hiding this comment.
Based on https://osu.ppy.sh/wiki/en/Beatmap, stable wording is wrong. Also, the term "mapsets" is rarely used in the wiki.
I just want consistency in wiki, lazer/stable, and web.
Edit: To answer your question, users may want to see the "beatmap" (wiki definition) number, so I don't think that should be changed.
The wording "X matches" being used when you didn't search for anything always bothered me, this also matches stable (though in stable the X beatmaps available text is in a different location).