Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skin mounting flow #30226

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+327 −3
Open

Add skin mounting flow #30226

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4d09e94
Initial implementation
smallketchup82 Sep 10, 2024
9de248f
Fix changes not being applied instantly, Improve import performance, …
smallketchup82 Sep 13, 2024
a20bd5c
Abstract out logic to SkinImporter
smallketchup82 Sep 23, 2024
b7883f1
Add a toggle for checking overwriting
smallketchup82 Oct 11, 2024
ee16c96
Make everything translatable
smallketchup82 Oct 11, 2024
2b7eb56
Rename oldskin
smallketchup82 Oct 11, 2024
0dc77a7
Revert "Add a toggle for checking overwriting"
smallketchup82 Oct 11, 2024
942efce
Merge branch 'master' into skin-mounting
smallketchup82 Oct 12, 2024
3d16e45
Remove a comment
smallketchup82 Oct 12, 2024
44fe7f2
Switch to using an overlay interface for skin mounting
smallketchup82 Oct 13, 2024
ca5a74d
Switch overlay colour scheme to purple
smallketchup82 Oct 13, 2024
15c7a12
Switch colour scheme to blue
smallketchup82 Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game/Overlays/ExternalEditOverlay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public partial class ExternalEditOverlay : OsuFocusedOverlayContainer
private FillFlowContainer flow = null!;

[Cached]
private readonly OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Pink);
private readonly OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Purple);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should inherit from the skin editor's colours, no?


[Resolved]
private GameHost gameHost { get; set; } = null!;
Expand Down
Loading