Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skin mounting flow #30226

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add skin mounting flow #30226

wants to merge 12 commits into from
+327 −3

Commits on Oct 11, 2024

  1. Initial implementation

    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4d09e94 View commit details
    Browse the repository at this point in the history

  2. Fix changes not being applied instantly, Improve import performance, … 

    …lay down framework for abstracting logic
    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9de248f View commit details
    Browse the repository at this point in the history

  3. Abstract out logic to SkinImporter

    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a20bd5c View commit details
    Browse the repository at this point in the history

  4. Add a toggle for checking overwriting 

    The GetFile method in AddFile has a huge overhead, given we're doing
this in a loop.

Since we clear the files in the skin, we already know there won't be any
existing files, so we can skip all of that logic
    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b7883f1 View commit details
    Browse the repository at this point in the history

  5. Make everything translatable

    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ee16c96 View commit details
    Browse the repository at this point in the history

  6. Rename oldskin

    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2b7eb56 View commit details
    Browse the repository at this point in the history

  7. Revert "Add a toggle for checking overwriting" 

    This reverts commit b7883f1.
    @smallketchup82
    smallketchup82 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0dc77a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merge branch 'master' into skin-mounting

    @smallketchup82
    smallketchup82 authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    942efce View commit details
    Browse the repository at this point in the history

  2. Remove a comment

    @smallketchup82
    smallketchup82 committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3d16e45 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Switch to using an overlay interface for skin mounting

    @smallketchup82
    smallketchup82 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    44fe7f2 View commit details
    Browse the repository at this point in the history

  2. Switch overlay colour scheme to purple 

    Figured this made sense since we're using purple buttons. It doesn't
really seem to change anything visually though
    @smallketchup82
    smallketchup82 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ca5a74d View commit details
    Browse the repository at this point in the history

  3. Switch colour scheme to blue

    @smallketchup82
    smallketchup82 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    15c7a12 View commit details
    Browse the repository at this point in the history