Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unnecessary properties from BeatmapInfo / realm to IBeatmap #28473

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Merge branch 'master' into beatmap-info-purge

58fe502
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Move unnecessary properties from BeatmapInfo / realm to IBeatmap #28473

Merge branch 'master' into beatmap-info-purge
58fe502
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Sep 14, 2024 in 0s

10467 passed, 4 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10545 tests were completed in 3106s with 10467 passed, 4 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen 16✅ 4❌ 14s

❌ osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen

✅ TestConstructor
✅ TestConstructor
✅ TestCreatedRoom
✅ TestCreatedRoom
✅ TestFreeModSelectionHasAllowedMods
✅ TestFreeModSelectionHasAllowedMods
✅ TestModSelectKeyWithAllowedMods
✅ TestModSelectKeyWithAllowedMods
✅ TestModSelectKeyWithNoAllowedMods
✅ TestModSelectKeyWithNoAllowedMods
✅ TestModSelectOverlay
✅ TestModSelectOverlay
✅ TestNextPlaylistItemSelectedAfterCompletion
❌ TestNextPlaylistItemSelectedAfterCompletion
	System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	)
	  ----> System.AggregateException : MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	
❌ TestSettingValidity
	System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	)
	  ----> System.AggregateException : MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	
✅ TestSettingValidity
❌ TestStartMatchWhileSpectating
	System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	)
	  ----> System.AggregateException : MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	
✅ TestStartMatchWhileSpectating
✅ TestTaikoOnlyMod
❌ TestTaikoOnlyMod
	System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2
	)
	  ----> System.AggregateException : MultiplayerClient test failure investigation
	Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
	   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
	Lookup                   : 1
	Items in Room.Playlist   : 1,2
	Items in APIRoom.Playlist: 2

Annotations

Check failure on line 795 in osu.Game/Online/Multiplayer/MultiplayerClient.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen ► TestNextPlaylistItemSelectedAfterCompletion 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
  )
    ----> System.AggregateException : MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
Raw output 
System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2
)
  ----> System.AggregateException : MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2

   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task)
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AggregateException
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 795
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Check failure on line 795 in osu.Game/Online/Multiplayer/MultiplayerClient.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen ► TestSettingValidity 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
  )
    ----> System.AggregateException : MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
Raw output 
System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2
)
  ----> System.AggregateException : MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2

   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AggregateException
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 795
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Check failure on line 795 in osu.Game/Online/Multiplayer/MultiplayerClient.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen ► TestStartMatchWhileSpectating 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
  )
    ----> System.AggregateException : MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
Raw output 
System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2
)
  ----> System.AggregateException : MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2

   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AggregateException
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 795
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Check failure on line 795 in osu.Game/Online/Multiplayer/MultiplayerClient.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiplayerMatchSubScreen ► TestTaikoOnlyMod 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
  )
    ----> System.AggregateException : MultiplayerClient test failure investigation
  Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
     at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
  Lookup                   : 1
  Items in Room.Playlist   : 1,2
  Items in APIRoom.Playlist: 2
Raw output 
System.AggregateException : One or more errors occurred. (MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2
)
  ----> System.AggregateException : MultiplayerClient test failure investigation
Exception                : System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, HashSet`1 appliedInstances)
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 781
Lookup                   : 1
Items in Room.Playlist   : 1,2
Items in APIRoom.Playlist: 2

   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AggregateException
   at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass122_0.<PlaylistItemChanged>b__0() in D:\a\osu\osu\osu.Game\Online\Multiplayer\MultiplayerClient.cs:line 795
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
View more details on GitHub Actions