Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unnecessary properties from BeatmapInfo / realm to IBeatmap #28473

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Merge branch 'master' into beatmap-info-purge

58fe502
Select commit
Loading
Failed to load commit list.
Draft

Move unnecessary properties from BeatmapInfo / realm to IBeatmap #28473

Merge branch 'master' into beatmap-info-purge
58fe502
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-09-14 19:54:06 ago

0 / 1 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
Closes #20883 Incomplete
Supersedes / closes #23418 Incomplete
Needs more testing probably, I've only checked that tests pass Incomplete
BeatmapInfo.BeatDivisor - can't really be moved out of realm because it's used for filtering in song select Incomplete
BeatmapInfo.EditorTimestamp could go live in the .osu file but I didn't want to make that change here as I would rather keep this diff strictly menial. Incomplete
If we're not going to have a general "class of info" that we're passing around, then I think EpilepsyWarning/WidescreenStoryboard should be moved into Storyboard. Incomplete
ReplacesBackground (BeatmapInfo.Metadata.BackgroundFile) - probably BackgroundFile should be duplicated as a property here. Incomplete
GetStoragePathFromStoryboardPath the directionality looks inverted. It should be DrawableStoryboard doing the lookups on resource stores, not what is effectively a model class otherwise. Incomplete