Skip to content

Reworked hit result generator based on accuracy #176

Reworked hit result generator based on accuracy

Reworked hit result generator based on accuracy #176

Triggered via pull request August 2, 2024 10:53
Status Failure
Total duration 1m 22s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 1 warning, and 10 notices
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L79
Name 'ratio50to100' does not match rule 'Local variables'. Suggested name is 'ratio50To100'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 79
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L82
Name 'count100estimate' does not match rule 'Local variables'. Suggested name is 'count100Estimate'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 82
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L85
Name 'count50estimate' does not match rule 'Local variables'. Suggested name is 'count50Estimate'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 85
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L97
Name 'count100estimate' does not match rule 'Local variables'. Suggested name is 'count100Estimate'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 97
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L100
Name 'count50estimate' does not match rule 'Local variables'. Suggested name is 'count50Estimate'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 100
Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L113
Name 'count50estimate' does not match rule 'Local variables'. Suggested name is 'count50Estimate'. in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 113
Code Quality: PerformanceCalculatorGUI/RulesetHelper.cs#L144
Name 'ratio50to100' does not match rule 'Local variables'. Suggested name is 'ratio50To100'. in PerformanceCalculatorGUI\RulesetHelper.cs on line 144
Code Quality: PerformanceCalculatorGUI/RulesetHelper.cs#L147
Name 'count100estimate' does not match rule 'Local variables'. Suggested name is 'count100Estimate'. in PerformanceCalculatorGUI\RulesetHelper.cs on line 147
Code Quality: PerformanceCalculatorGUI/RulesetHelper.cs#L150
Name 'count50estimate' does not match rule 'Local variables'. Suggested name is 'count50Estimate'. in PerformanceCalculatorGUI\RulesetHelper.cs on line 150
Code Quality: PerformanceCalculatorGUI/RulesetHelper.cs#L162
Name 'count100estimate' does not match rule 'Local variables'. Suggested name is 'count100Estimate'. in PerformanceCalculatorGUI\RulesetHelper.cs on line 162
Code Quality
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code Quality: PerformanceCalculatorGUI/APIManager.cs#L28
Convert into primary constructor in PerformanceCalculatorGUI\APIManager.cs on line 28
Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L27
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 27
Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L52
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 52
Code Quality: PerformanceCalculatorGUI/Components/ExtendedProfileScore.cs#L43
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedProfileScore.cs on line 43
Code Quality: PerformanceCalculatorGUI/Components/ExtendedUserModSelectOverlay.cs#L12
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedUserModSelectOverlay.cs on line 12
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L34
Use collection expression in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 34
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L50
Use collection expression in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 50
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L97
Convert into primary constructor in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 97
Code Quality: PerformanceCalculatorGUI/Components/ScreenSelectionButtonIcon.cs#L12
Convert into primary constructor in PerformanceCalculatorGUI\Components\ScreenSelectionButtonIcon.cs on line 12
Code Quality: PerformanceCalculatorGUI/Components/StatefulButton.cs#L32
Convert into primary constructor in PerformanceCalculatorGUI\Components\StatefulButton.cs on line 32