-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked hit result generator based on accuracy #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add explanation on what this is doing and why. All I see is logic with no clear reasoning on why it does what it does.
Added very detailed explanation of what I'm doing here. You can remove unnecessary things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy your implementation to the CLI perfcalc as well: https://github.com/ppy/osu-tools/blob/master/PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L63
and changed the order a bit to be more readable
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI issues
CodeFactor is fine, don't mind that too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say a lot of this is redundant (does it really matter if scores below 25% accuracy are accurately calculated?..) but I guess it doesnt hurt to have
It used to just spam 50s until it reach target accuracy
Now it's actually trying to fit it in realistic way