Implement phpstan 5

front/info.form.php

@@ -44,6 +44,6 @@
     }
     Html::back();
 }
-
+/** @phpstan-ignore-next-line */
 Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$5');
 Html::back();

front/mapping.form.php

@@ -72,6 +72,7 @@
                 $_POST['models_id'],
                 PluginDatainjectionModel::OTHERS_STEP
             );
+            /** @phpstan-ignore-next-line */
             Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$5');
             Session::addMessageAfterRedirect(
                 __(

front/model.form.php

@@ -47,6 +47,7 @@
     $newID = $model->add($_POST);
 
     //Set display to the advanced options tab
+    /** @phpstan-ignore-next-line */
     Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$3');
     Html::redirect(Toolbox::getItemTypeFormURL('PluginDatainjectionModel') . "?id=$newID");
 } else if (isset($_POST["delete"])) {
@@ -80,6 +81,7 @@
                 ]
             )
         ) {
+            /** @phpstan-ignore-next-line */
             Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$4');
         } else {
             Session::addMessageAfterRedirect(

hook.php

@@ -52,7 +52,7 @@ function plugin_datainjection_install()
 
     include_once Plugin::getPhpDir('datainjection') . "/inc/profile.class.php";
 
-    $migration = new Migration(null);
+    $migration = new Migration(PLUGIN_DATAINJECTION_VERSION);
 
     $default_charset = DBConnection::getDefaultCharset();
     $default_collation = DBConnection::getDefaultCollation();
@@ -1990,7 +1990,6 @@ function plugin_datainjection_addDefaultWhere($itemtype)
             } else {
                 return "1 = 0"; //no model available -> force WHERE clause to get no result
             }
-            return false;
         default:
             break;
     }

inc/autoupdatesysteminjection.class.php

@@ -78,7 +78,7 @@ public function getOptions($primary_type = '')
     * @param $values  array fields to add into glpi
     * @param $options array options used during creation
     *
-    * @return an array of IDs of newly created objects : for example array(Computer=>1, Networkport=>10)
+    * @return array of IDs of newly created objects : for example array(Computer=>1, Networkport=>10)
    **/
     public function addOrUpdateObject($values = [], $options = [])
     {

inc/backend.class.php

@@ -105,7 +105,7 @@ public static function toUTF8($string)
     {
 
         if (!self::is_utf8($string)) {
-            return utf8_encode($string);
+            return mb_convert_encoding($string, 'UTF-8');
         }
         return $string;
     }

inc/clientinjection.class.php

@@ -40,10 +40,10 @@ class PluginDatainjectionClientInjection
     private $results = [];
 
     //Model used for injection
-    private $model;
+    private $model; /** @phpstan-ignore-line */
 
     //Overall injection results
-    private $global_results;
+    private $global_results; /** @phpstan-ignore-line */
 
 
     /**