Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement phpstan 5 #399

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement phpstan 5 #399

wants to merge 9 commits into from

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Jun 5, 2024

No description provided.

stonebuzz
stonebuzz requested changes Jun 5, 2024
View reviewed changes
hook.php Outdated Show resolved Hide resolved
inc/autoupdatesysteminjection.class.php Outdated Show resolved Hide resolved
inc/commoninjectionlib.class.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from stonebuzz June 5, 2024 12:56
Rom1-B
Rom1-B requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of @phpstan-ignore..., we can have a few, but >50 is a lot.
If level 5 is too ambitious, maybe we need to validate an intermediate level first?

inc/commoninjectionlib.class.php Outdated Show resolved Hide resolved
inc/commoninjectionlib.class.php Outdated Show resolved Hide resolved
inc/commoninjectionlib.class.php Outdated Show resolved Hide resolved
Rom1-B
Rom1-B requested changes Jun 10, 2024
View reviewed changes
inc/commoninjectionlib.class.php Outdated Show resolved Hide resolved
inc/injectiontype.class.php Outdated Show resolved Hide resolved
inc/injectiontype.class.php Outdated Show resolved Hide resolved
inc/model.class.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B June 10, 2024 08:33
Rom1-B
Rom1-B reviewed Jun 10, 2024
View reviewed changes
inc/model.class.php Outdated Show resolved Hide resolved
Rom1-B
Rom1-B reviewed Jun 10, 2024
View reviewed changes
inc/model.class.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B June 12, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lainow @stonebuzz @Rom1-B