-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkey support for TimeControlNode #682
Comments
Also consider adding common-code support for TimeControlNode keyboard help content. See phetsims/fourier-making-waves#93. |
In phetsims/fourier-making-waves#93 (comment), I noted that Fourier will (someday) need hotkey support for TimeControlNode. (This will not be included in Fourier 1.0, see phetsims/fourier-making-waves#92 (comment).)
In phetsims/fourier-making-waves#93 (comment), @jessegreenberg replied:
|
Reviewing scenery-phet issues for Q4 2022 planning... There has been no progress on this, assigned to @jessegreenberg with no response. We worked around this in Fourier, but it's needed in MOTHA. @kathy-phet please prioritize. |
Subset of phetsims/scenery#1298 |
Reviewing this issue as of 2/23/24 -
|
We visited this during a prioritization meeting and want to have an approach for 'hotkey registry' working before we add more hotkeys to common code components like this. |
TimeControlNode needs a comprehensive hotkey design. It has some partical support, but there has been no holistic design.
One of its subcomponent (PlayPauseButton) supports a hot key by default, while the other subcomponents (StepForwardButton, StepBackwardButton) do not support hot keys. PlayPauseButton hotkey is enabled by default, which feels odd. And MAL added its own StepForwardButton support, which should be in TimeControlNode, see #681.
This is not blocking for Fourier 1.0. I'm planning to disabled hotkey support for TimeControlNode's subcomponents.
The text was updated successfully, but these errors were encountered: