-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkeys for TimeControlNode in Discrete screen #92
Comments
TimeControlNode has not had a comprehensive hotkey design. One of its subcomponent (PlayPauseButton) supports a hotkey by default, while the other subcomponents (StepForwardButton, StepBackwardButton) do not support hotkeys. I think it would be odd to have partial support, so I'm going to disable the play/pause hotkey until there's uniform support - see phetsims/scenery-phet#682. I've told @jessegreenberg that this is not blocking for Fourier 1.0 release. @arouinfar do you agree? |
I was confused by this statement because MAL does have a hotkey for StepForwardButton:
But then I saw what @pixelzoom said in phetsims/scenery-phet#682:
@pixelzoom I agree that this is not blocking, as the TimeControlNode is not critical to the learning goals of Fourier: Making Waves. |
Thanks @arouinfar. Marking this issue as deferred, to be addressed in the future (after 1.0). The general issue for TimeControlNode hotkeys is phetsims/scenery-phet#682. |
Does TimeControlNode have hotkey support?
If so, is it enabled by default, or should it be enabled?
If so, what keyboard help should be added to the Discrete screen?
The text was updated successfully, but these errors were encountered: