Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys for TimeControlNode in Discrete screen #92

Open
pixelzoom opened this issue Jun 22, 2021 · 3 comments
Open

Hotkeys for TimeControlNode in Discrete screen #92

pixelzoom opened this issue Jun 22, 2021 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 22, 2021

Does TimeControlNode have hotkey support?
If so, is it enabled by default, or should it be enabled?
If so, what keyboard help should be added to the Discrete screen?

@pixelzoom pixelzoom self-assigned this Jun 22, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 22, 2021

TimeControlNode has not had a comprehensive hotkey design. One of its subcomponent (PlayPauseButton) supports a hotkey by default, while the other subcomponents (StepForwardButton, StepBackwardButton) do not support hotkeys. I think it would be odd to have partial support, so I'm going to disable the play/pause hotkey until there's uniform support - see phetsims/scenery-phet#682.

I've told @jessegreenberg that this is not blocking for Fourier 1.0 release. @arouinfar do you agree?

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Jun 22, 2021
@pixelzoom pixelzoom changed the title Are there hot keys for TimeControlNode? Are there hotkeys for TimeControlNode? Jun 22, 2021
@pixelzoom pixelzoom changed the title Are there hotkeys for TimeControlNode? Hotkeys for TimeControlNode Jun 22, 2021
@arouinfar
Copy link
Contributor

I was confused by this statement because MAL does have a hotkey for StepForwardButton:

One of its subcomponent (PlayPauseButton) supports a hotkey by default, while the other subcomponents (StepForwardButton, StepBackwardButton) do not support hotkeys.

But then I saw what @pixelzoom said in phetsims/scenery-phet#682:

And MAL added its own StepForwardButton support, which should be in TimeControlNode, see phetsims/scenery-phet#681.

@pixelzoom I agree that this is not blocking, as the TimeControlNode is not critical to the learning goals of Fourier: Making Waves.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Jun 24, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 24, 2021

Thanks @arouinfar. Marking this issue as deferred, to be addressed in the future (after 1.0).

The general issue for TimeControlNode hotkeys is phetsims/scenery-phet#682.

@pixelzoom pixelzoom removed their assignment Jun 24, 2021
@pixelzoom pixelzoom changed the title Hotkeys for TimeControlNode Hotkeys for TimeControlNode in Discrete screen Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants