Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global hotkey for the StepForwardButton should be moved to common code #681

Closed
jessegreenberg opened this issue Jun 22, 2021 · 4 comments
Closed
Assignees

Comments

@jessegreenberg
Copy link
Contributor

There is currently a hotkey added in molecules-and-light that steps forward the simulation when pressing alt + "l". This should be moved to common code. Most likely to StepForwardButton.

@pixelzoom
Copy link
Contributor

Related to #682.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 22, 2021

If move to StepForwardButton, it should be the default hotkey, not the only possible hotkey. As we concluded in our Slack discussion about hotkey support in common-code:

Provide a nice default that fits most contexts. Allow the client to override to fit a different context.

@pixelzoom pixelzoom changed the title Global hot key for the StepForwardButton should be moved to common code Global hotkey for the StepForwardButton should be moved to common code Jun 22, 2021
@zepumph
Copy link
Member

zepumph commented Oct 6, 2022

Subset of phetsims/scenery#1298

@jessegreenberg
Copy link
Contributor Author

This would be done with #682 , we don't need to track this in its own issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants