Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16373 #16380

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Issue 16373 #16380

merged 4 commits into from
Jul 26, 2023

Conversation

sinbadxiii
Copy link
Contributor

@sinbadxiii sinbadxiii commented Jul 25, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

In the issue I have suggested different solutions,
this variant will not break compatibility and allow to have an associative array check.

Thanks!

@niden
Copy link
Member

niden commented Jul 25, 2023

@sinbadxiii This is great. Can you also add a line to the changelog please?

@niden niden self-requested a review July 25, 2023 14:43
@sinbadxiii
Copy link
Contributor Author

@sinbadxiii This is great. Can you also add a line to the changelog please?

Sure, I will do it

@sinbadxiii
Copy link
Contributor Author

sinbadxiii commented Jul 26, 2023

@sinbadxiii This is great. Can you also add a line to the changelog please?

Done
I also replaced json_decode in Request::getJsonRawBody by Phalcon\Support\Helper\Json\Decode as it was written in other similar code in 5.0.x
I hope it was the correct solution :)
tests pass successfully

@niden niden merged commit 4294990 into phalcon:5.0.x Jul 26, 2023
38 checks passed
@niden
Copy link
Member

niden commented Jul 26, 2023

Thank you @sinbadxiii

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jul 26, 2023
@niden niden linked an issue Jul 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Unable to use JWT Parser when getJsonRawBody is called
2 participants