[BUG]: Unable to use JWT Parser when getJsonRawBody is called

[dz3n]

Describe the bug
If getJsonRawBody is called, JWT parser throws an error instead of the parsed JWT

To Reproduce

use Phalcon\Encryption\Security\JWT\Signer\Hmac;
use Phalcon\Encryption\Security\JWT\Token\Parser;
...

$request = Di::getDefault()->get('request');

/**
 * If this line is removed the code works fine
 */
$payload = $request->getJsonRawBody(true);


$jwt = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ0ZXN0IjoiMSIsImlhdCI6MTY4ODgzNDY2MywiZXhwIjoxNjg4ODM4MjYzfQ.i0Cwm4uHqAwyZ_gWZpDA3sUdha56HxngkvFE2Mz5tsM';

$parser = new Parser();
$signer = new Hmac();

$tokenObject = $parser->parse($jwt);
$data = $tokenObject->getClaims()->getPayload();

var_dump($data);

If $payload = $request->getJsonRawBody(true); exists I get json_decode error: Syntax error instead of the parsed JWT

Details

• Phalcon version: 5.0.4
• PHP Version: PHP 8.1.7
• Operating System:
• Installation type: Ubuntu + Docker
• Server: Nginx

[sinbadxiii]

The problem really exists
There is no json_decode error checking in the Request

    public function getJsonRawBody(bool associative = false) -> <\stdClass> | array | bool
    {
        var rawBody;

        let rawBody = this->getRawBody();

        if typeof rawBody != "string" {
            return false;
        }

        return json_decode(rawBody, associative);
    }

We can do validation and then an error will be shown for empty request and all projects will fail :)

    public function getJsonRawBody(bool associative = false) -> <\stdClass> | array | bool
    {
        var rawBody;

        let rawBody = this->getRawBody();

        if typeof rawBody != "string" {
            return false;
        }

        var decoded;

        let decoded = json_decode(rawBody, associative);

        if unlikely JSON_ERROR_NONE !== json_last_error() {
            throw new \InvalidArgumentException(
                "json_decode error: " . json_last_error_msg()
            );
        }

        return decoded;
    }

or this problem can be solved if we just will return stdClass if rawBody == ""

    public function getJsonRawBody(bool associative = false) -> <\stdClass> | array | bool
    {
        var rawBody;

        let rawBody = this->getRawBody();

        if typeof rawBody != "string" {
            return false;
        }

        if rawBody == ""
        {
            return new \stdClass();  //or let rawBody == "{}"; as variant to work associative array
        }

        return json_decode(rawBody, associative);
    }

Guys what do you think? what's better?

[niden]

Resolved in #16380