PMM-13543 Support socket path. #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMM-13477 Support of PSMDB 8.0.
BupycHuk
requested review from
ademidoff and
JiriCtvrtka
and removed request for
a team
ademidoff
approved these changes
Nov 14, 2024
JiriCtvrtka
approved these changes
Nov 14, 2024
Co-authored-by: Alex Demidoff <[email protected]>
ademidoff
reviewed
Nov 14, 2024
|
|
||
| // IF user@pass not contained in uri AND custom user and pass supplied in arguments | ||
| // DO concat a new uri with user and pass arguments value | ||
| if !strings.Contains(uri, "@") && user != "" && password != "" { |
There was a problem hiding this comment.
I'm wondering if we shouldn't support a case where the user is non-empty and the password is empty.
There was a problem hiding this comment.
good point for improvement, but in scope of this fix I think we can leave as it used to be. I just reverted old logic for cases where url.Parse doesn't work. Additionally for that users can set user in initial DSN. let's create github issue with good-first-task label for those who would like to contribute
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13477 Support of PSMDB 8.0.
PMM-13543 Support socket path.
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.