Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic data merge logic for MongoDB #963

Closed

Conversation

KeisukeYamashita
Copy link

PMM-XXXX (optional, if ticket reported)


Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@it-percona-cla
Copy link

it-percona-cla commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review November 14, 2024 14:47
@KeisukeYamashita KeisukeYamashita requested a review from a team as a code owner November 14, 2024 14:47
@KeisukeYamashita KeisukeYamashita requested review from ademidoff and BupycHuk and removed request for a team November 14, 2024 14:48
@BupycHuk
Copy link
Member

we've already fixed this problem, release of v0.42.1 was an accident, we will release stable v0.43.0 soon

@BupycHuk BupycHuk closed this Nov 14, 2024
@KeisukeYamashita
Copy link
Author

KeisukeYamashita commented Nov 14, 2024

Yeah, I saw this #961, thank you 👍

@KeisukeYamashita KeisukeYamashita deleted the fix-panic-on-mongo-8 branch November 14, 2024 14:49
@BupycHuk
Copy link
Member

it's in #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants