Fix unstable-light-client + ChainHeadBackend tx events #1865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numPeers
from the "broadcasted" TX event (the entire event is no longer in the spec but we keep it around for now just because Smoldot still returns it: Remove "number of peers broadcasted to" info from TX events smol-dot/smoldot#2033)broadcasted
from the "dropped" TX event (also no longer in the spec)Both of these changes should be backward compatible: it doesn't matter if the JSON returned contains the removed fields.
Oddly, when encountering the error, I was noticing that Smoldot was returning the JSON we expected ie
{"event":"broadcasted","numPeers":1}
. I'm not sure why this wasn't being properly deserialized by us in the first place (we expectnum_peers
but alsorename_all = "camelCase"
so it should line up).This can be tested by running the following example, which fails prior to this change and passes after it:
Supercedes #1863