Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing fails when using lightclient feature for Wasm Apps #1862

Closed
paulormart opened this issue Nov 12, 2024 · 5 comments
Closed

Signing fails when using lightclient feature for Wasm Apps #1862

paulormart opened this issue Nov 12, 2024 · 5 comments

Comments

@paulormart
Copy link
Contributor

Hi Team, when using the unstable-light-client feature to build Wasm Apps, the transactions are not successfully submitted to the network, raising the error below:

SubxtError(Serialization(Error("missing field `num_peers`", line: 0, column: 0)))
@niklasad1
Copy link
Member

niklasad1 commented Nov 12, 2024

I think the broadcast event was removed from transactionWatch API, paritytech/json-rpc-interface-spec#134

So, we should remove it but I guess we could make it an num_peers: Option<u32> to begin with to work with older versions but quite weird that this event is generated without a count...

What do you guys reckon @jsdw @lexnv?

@jsdw
Copy link
Collaborator

jsdw commented Nov 12, 2024

Agreed that we should just remove the Broadcasted event entirely since it's not a part of the stable spec (and the broadcasted: bool from the Dropped event).

But yeah, that wouldn't resolve this issue. In the spec, it doesn't appear that there was ever a version with the "broadcasted" event but no number, so I'm not sure how this would happen. @paulormart do you have an easy way to reproduce this with a specific chain, and which chain did the error crop up on?

@paulormart
Copy link
Contributor Author

paulormart commented Nov 12, 2024

@jsdw the easiest way to reproduce that I found, was to run the wasm-example with the unstable-light-client enabled and replace the default OnlineClient with a backend using a LightClient loaded from a network chain spec.

I currently have this implemented on my own branch here using the Paseo network chainspec. And also pushed a PR with these changes here d19dd5a

@jsdw
Copy link
Collaborator

jsdw commented Nov 12, 2024

Thanks!

I opened #1865 to address this; it was a little like your PR but more aggressive in removing fields that were no longer a part of the spec :)

I didn't commit to using Paseo in the lightclient WASM example but instead reprocuded using a native light client example.

@jsdw
Copy link
Collaborator

jsdw commented Nov 13, 2024

Closed by #1865

@jsdw jsdw closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants