explicitly annotate type of wrap_on_hostcall
#93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap_on_hostcall
has a generic parameterS
. When calling the function this parameter is instantiated with some inference variable -_
- Let's call it?unknown
for now.When calling
exec_args.set_on_hostcall
we end up equatingfor<'r> <S as SandBox>::Access<'r>
withfor<'r> <?unknown as SandBox>::Access<'r>
. This currently constrains?unknown
toS
, even though this may not strictly be the case.There could theoretically exist an impl like
with this using
wrap_on_hostcall::<Wrapper<S>>(on_hostcall);
would also compile.Your code previously compiled due to a shortcoming of rustc when handling higher ranked regions. This will be fixed in rust-lang/rust#119849 at which point your code will fail with ambiguity.