Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: type inference changes #123290

Closed
Mark-Simulacrum opened this issue Mar 31, 2024 · 2 comments
Closed

regression: type inference changes #123290

Mark-Simulacrum opened this issue Mar 31, 2024 · 2 comments
Labels
E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

[INFO] [stdout] error[E0283]: type annotations needed
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/polkavm-0.3.0/src/compiler.rs:424:31
[INFO] [stdout]     |
[INFO] [stdout] 424 |         let mut on_hostcall = wrap_on_hostcall(on_hostcall);
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^ cannot infer type of the type parameter `S` declared on the function `wrap_on_hostcall`
[INFO] [stdout]     |
[INFO] [stdout]     = note: cannot satisfy `_: sandbox::Sandbox`
[INFO] [stdout]     = help: the following types implement trait `sandbox::Sandbox`:
[INFO] [stdout]               generic::Sandbox
[INFO] [stdout]               sandbox::linux::Sandbox
[INFO] [stdout] note: required by a bound in `wrap_on_hostcall`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/polkavm-0.3.0/src/compiler.rs:417:138
[INFO] [stdout]     |
[INFO] [stdout] 417 | ...s<'r>) -> Result<(), Trap> + '_ where S: Sandbox {
[INFO] [stdout]     |                                             ^^^^^^^ required by this bound in `wrap_on_hostcall`
[INFO] [stdout] help: consider specifying the generic argument
[INFO] [stdout]     |
[INFO] [stdout] 424 |         let mut on_hostcall = wrap_on_hostcall::<S>(on_hostcall);
[INFO] [stdout]     |                                               +++++
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 31, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.78.0 milestone Mar 31, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 31, 2024
@Mark-Simulacrum Mark-Simulacrum added E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 31, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Apr 1, 2024

This is a known regression that was FCPd #119849 (comment) and it was also fixed by lcnr in paritytech/polkavm#93

@apiraino
Copy link
Contributor

apiraino commented Apr 2, 2024

@compiler-errors do the breaking changes in #119849 need to be in the release notes?

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants