-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): make benchmark inputs deterministic #13536
Conversation
Edited the PR description because it doesn't actually close the original issue, just modifies a few benches (there are more). Also edited it to be more descriptive - would highly appreciate similar quality descriptions in the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit, otherwise this looks good to me
CodSpeed Performance ReportMerging #13536 will degrade performances by 20.1%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Towards #13535
Changes state root task and channel perf benches to use the deterministic proptest runner