Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): make benchmark inputs deterministic #13536

Merged
merged 19 commits into from
Dec 30, 2024

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Dec 23, 2024

Towards #13535

Changes state root task and channel perf benches to use the deterministic proptest runner

@hoank101 hoank101 changed the title feat: make benchmark inputs deterministic feat(engine): make benchmark inputs deterministic Dec 27, 2024
@hoank101 hoank101 marked this pull request as ready for review December 27, 2024 13:47
@Rjected
Copy link
Member

Rjected commented Dec 27, 2024

Edited the PR description because it doesn't actually close the original issue, just modifies a few benches (there are more). Also edited it to be more descriptive - would highly appreciate similar quality descriptions in the future!

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, otherwise this looks good to me

crates/engine/tree/benches/state_root_task.rs Outdated Show resolved Hide resolved
@hoank101 hoank101 requested a review from Rjected December 28, 2024 02:39
Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #13536 will degrade performances by 20.1%

Comparing hoank101:hoa/13535 (fc7292c) with main (91dd417)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 74 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main hoank101:hoa/13535 Change
`sparse trie[init size 10000 update size 100 num updates 3]` 10.1 ms
`receipts root size: 10 HashBuilder` 119.5 µs
ordered_trie_root 139.7 µs 123.9 µs +12.77%

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Dec 30, 2024
Merged via the queue into paradigmxyz:main with commit 8b60ff1 Dec 30, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants