-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make benchmark inputs deterministic #13535
Labels
C-benchmark
A change that impacts how or what we benchmark
D-good-first-issue
Nice and easy! A great choice to get started
Comments
DaniPopes
added
the
D-good-first-issue
Nice and easy! A great choice to get started
label
Dec 23, 2024
hi @DaniPopes i can do it |
May I pick this up? |
Can I attempt this issue? |
Can I be assigned to this? |
@ekumamatthew @aidenwong812 @rutefig there are more benches to make deterministic after #13536, feel free to submit PRs! |
I’d love to work on this task. |
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-benchmark
A change that impacts how or what we benchmark
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
there are a few benchmarks that use default proptest to generate their inputs, however this is not ideal because the randomness creates a lot of noise on codspeed
these should be changed to use the deterministic proptest runner (TestRunner::deterministic()) or rng (TestRng::deterministic_rng) when creating inputs
you can find all occurences by searching for "proptest" under benches/ paths
Additional context
No response
The text was updated successfully, but these errors were encountered: