Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-6457] Don't check file system when host has protocol/scheme. #466

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
402461b
Prepare 1.4.3-dev
pwtyler May 15, 2023
69c194f
fix: Fixes assumption that CACHE_PORT & CACHE_PASSWORD are Set. (#360)
timnolte Jun 5, 2023
bf8e124
Adjust CONTRIBUTING Guidelines (#427)
pwtyler Jun 6, 2023
7248457
[CMSP-459] Updates behat tests and behaviors. (#430)
rwagner00 Jun 23, 2023
d1b6103
[CMSP-459] bugfix: re-add missing else (#437)
jazzsequence Jun 23, 2023
16f20bd
add wporg validator action (#435)
jazzsequence Jun 23, 2023
c3a5242
fix: Fixes incorrect order of array_replace_recursive arguments & oth…
timnolte Jun 23, 2023
154aa80
Prepare 1.4.5-dev
jazzsequence Nov 27, 2023
44c2817
Fix typos (#452)
szepeviktor Nov 28, 2023
0961b6c
Bump behat/behat from 3.13.0 to 3.14.0 (#453)
dependabot[bot] Feb 2, 2024
831918d
Bump pantheon-systems/pantheon-wp-coding-standards from 1.0.1 to 2.0.1
dependabot[bot] Feb 7, 2024
9cd4efb
linting fixes
jazzsequence Feb 7, 2024
0a67524
add composer diff
jazzsequence Feb 7, 2024
6928695
Merge branch 'dependabot/composer/default/pantheon-systems/pantheon-w…
jazzsequence Feb 7, 2024
279bb1f
Change default branch for dependabot to "main" (#456)
jazzsequence Feb 7, 2024
1e8e95b
Bump yoast/phpunit-polyfills from 1.1.0 to 2.0.0 (#455)
dependabot[bot] Feb 7, 2024
fccd9c4
Bump pantheon-systems/wpunit-helpers from 1.0.1 to 2.0.0 (#457)
dependabot[bot] Feb 16, 2024
a5e35f9
Bump yoast/phpunit-polyfills from 2.0.0 to 2.0.1 (#458)
dependabot[bot] Apr 11, 2024
2fa07d3
Bump pantheon-systems/pantheon-wp-coding-standards from 2.0.1 to 2.0.…
dependabot[bot] Jul 10, 2024
ae3e794
Update CODEOWNERS for new team names (#462)
greg-1-anderson Aug 28, 2024
b4b2e43
Add or update catalog-info.yml
namespacebrian Sep 10, 2024
95c727c
[SITE-1547] Add catalog-info.yml (#464)
namespacebrian Sep 10, 2024
fe5f0db
Don't check file system when host has protocol/scheme.
EarthlingDavey Sep 20, 2024
f51856e
Change matching to explicit tls, redis & rediss protocols.
EarthlingDavey Sep 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
echo "GITHUB_TOKEN environment variables missing; assuming unauthenticated build"
exit 0
fi
echo "Setting GitHub OAuth token with suppressed ouput"
echo "Setting GitHub OAuth token with suppressed output"
{
composer config -g github-oauth.github.com $GITHUB_TOKEN
} &> /dev/null
Expand Down
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ updates:
interval: weekly
timezone: America/Los_Angeles
day: tuesday
target-branch: "default"
target-branch: "main"
open-pull-requests-limit: 99
ignore:
- dependency-name: phpunit/phpunit
Expand All @@ -16,4 +16,4 @@ updates:
- dependency-name: phpunit/phpunit
versions:
- ">= 9.a"
- "< 10"
- "< 10"
28 changes: 28 additions & 0 deletions .github/workflows/composer-diff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Composer Diff
on:
pull_request:
paths:
- 'composer.lock'
permissions:
contents: write
pull-requests: write
jobs:
composer-diff:
name: Composer Diff
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Generate composer diff
id: composer_diff
uses: IonBazan/composer-diff-action@v1
- uses: marocchino/sticky-pull-request-comment@v2
if: ${{ steps.composer_diff.outputs.composer_diff_exit_code != 0 }}
with:
header: composer-diff
message: |
<summary>Composer Changes</summary>

${{ steps.composer_diff.outputs.composer_diff }}
2 changes: 2 additions & 0 deletions .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ jobs:
path: ~/vendor
key: test-dependencies-{{ checksum "composer.json" }}
restore-keys: test-dependencies-{{ checksum "composer.json" }}
- name: Setup WP-CLI
uses: godaddy-wordpress/setup-wp-cli@1
- name: Install dependencies
run: |
if [ ${{ matrix.php_version }} = "7.4" ]; then
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/wporg-validator.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# On push, run the action-wporg-validator workflow.
name: WP.org Validator
on: [push]
jobs:
wporg-validation:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: WP.org Validator
uses: pantheon-systems/[email protected]
with:
type: plugin
2 changes: 1 addition & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @pantheon-systems/cms-platform @pantheon-systems/cms-ecosystem
* @pantheon-systems/site-experience
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Pull requests and issues are welcome!

Development and releases are structured around two branches, `main` and `release`. The `main` branch is the default branch for the repository, and is the source and destination for feature branches.

We prefer to squash commits (i.e. avoid merge PRs) from a feature branch into `main` when merging, and to include the PR # in the commit message. PRs to `main` should also include any relevent updates to the changelog in readme.txt. For example, if a feature constitutes a minor or major version bump, that version update should be discussed and made as part of approving and merging the feature into `main`.
We prefer to squash commits (i.e. avoid merge PRs) from a feature branch into `main` when merging, and to include the PR # in the commit message. PRs to `main` should also include any relevant updates to the changelog in readme.txt. For example, if a feature constitutes a minor or major version bump, that version update should be discussed and made as part of approving and merging the feature into `main`.

`main` should be stable and usable, though possibly a few commits ahead of the public release on wp.org.

Expand Down Expand Up @@ -51,7 +51,7 @@ The behat tests require a Pantheon site with Redis enabled. Once you've created
* `git pull origin release`
* `git checkout main`
* `git rebase release`
* Update the version number in all locations, incrementing the version by one patch version, and add the `-dev` flag (e.g. after releasing `1.2.3`, the new verison will be `1.2.4-dev`)
* Update the version number in all locations, incrementing the version by one patch version, and add the `-dev` flag (e.g. after releasing `1.2.3`, the new version will be `1.2.4-dev`)
* Add a new `** X.Y.X-dev **` heading to the changelog
* `git add -A .`
* `git commit -m "Prepare X.Y.X-dev"`
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
**Tags:** cache, plugin, redis
**Requires at least:** 3.0.1
**Tested up to:** 6.4.1
**Stable tag:** 1.4.4
**Stable tag:** 1.4.5-dev
**License:** GPLv2 or later
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -96,7 +96,7 @@ This plugin is for the internal application object cache. It doesn't have anythi

### How do I disable the persistent object cache for a bad actor? ###

A page load with 2,000 Redis calls can be 2 full seonds of object cache transactions. If a plugin you're using is erroneously creating a huge number of cache keys, you might be able to mitigate the problem by disabling cache persistency for the plugin's group:
A page load with 2,000 Redis calls can be 2 full seconds of object cache transactions. If a plugin you're using is erroneously creating a huge number of cache keys, you might be able to mitigate the problem by disabling cache persistency for the plugin's group:

wp_cache_add_non_persistent_groups( array( 'bad-actor' ) );

Expand All @@ -108,6 +108,8 @@ There's a known issue with WordPress `alloptions` cache design. Specifically, a

## Changelog ##

### 1.4.5-dev ###

### 1.4.4 (November 27, 2023) ###
* Updates Pantheon WP Coding Standards to 2.0 [[#445](https://github.com/pantheon-systems/wp-redis/pull/445)]
* Handle duplicate keys in `get_multiple` function [[#448](https://github.com/pantheon-systems/wp-redis/pull/448)] (props @Souptik2001)
Expand Down
12 changes: 12 additions & 0 deletions catalog-info.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
name: wp-redis
description: Auto-generated catalog info for pantheon-systems/wp-redis
annotations:
backstage.io/techdocs-ref: dir:docs/
spec:
type: library
lifecycle: mature
owner: site
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"pantheon-systems/pantheon-wp-coding-standards": "^2.0",
"pantheon-systems/pantheon-wordpress-upstream-tests": "dev-master",
"phpunit/phpunit": "^9",
"yoast/phpunit-polyfills": "^1.0",
"pantheon-systems/wpunit-helpers": "^1.0"
"yoast/phpunit-polyfills": "^2.0",
"pantheon-systems/wpunit-helpers": "^2.0"
},
"scripts": {
"lint": [
Expand Down
Loading